Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRI-O integration [9 failures] #16403

Closed
runcom opened this issue Sep 18, 2017 · 13 comments
Closed

CRI-O integration [9 failures] #16403

runcom opened this issue Sep 18, 2017 · 13 comments

Comments

@runcom
Copy link
Member

runcom commented Sep 18, 2017

We're running Origin tests with CRI-O here: https://ci.openshift.redhat.com/jenkins/job/test_branch_origin_extended_conformance_crio/

From some preliminary runs we're down to the failures below:

Summarizing 10 Failures:
 
[Fail] [builds][Conformance] s2i build with a quota Building from a template [It] should create an s2i build with a quota and run it
/go/src/github.com/openshift/origin/test/extended/builds/s2i_quota.go:43
 
[Fail] [Conformance][templates] templateservicebroker security test [It] should pass security tests
/go/src/github.com/openshift/origin/test/extended/templates/templateservicebroker_security.go:91
 
[Fail] [builds] Optimized image builds [It] should succeed [Conformance]
/go/src/github.com/openshift/origin/test/extended/builds/optimized.go:60
 
[Fail] [k8s.io] Projected [It] should project all components that make up the projection API [Conformance] [Volume] [Projection]
/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/util.go:2224
 
[Fail] [Conformance][templates] templateinstance readiness test [It] should report ready soon after all annotated objects are ready
/go/src/github.com/openshift/origin/test/extended/templates/templateinstance_readiness.go:144
 
[Fail] [builds][Conformance][valueFrom] process valueFrom in build strategy environment variables [It] should successfully resolve valueFrom in s2i build environment variables
/go/src/github.com/openshift/origin/test/extended/builds/valuefrom.go:58
 
[Fail] [builds][Conformance] build without output image building from templates [It] should create an image from a S2i template without an output image reference defined
/go/src/github.com/openshift/origin/test/extended/builds/no_outputname.go:45
 
[Fail] [builds][Conformance] oc new-app [It] should succeed with a --name of 58 characters
/go/src/github.com/openshift/origin/test/extended/builds/new_app.go:49
 
[Fail] [Conformance][templates] templateservicebroker end-to-end test [It] should pass an end-to-end test
/go/src/github.com/openshift/origin/test/extended/templates/templateservicebroker_e2e.go:106
 
[Fail] [k8s.io] StatefulSet [k8s.io] Basic StatefulSet functionality [StatefulSetBasic] [It] Should recreate evicted statefulset
/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/statefulset.go:820
 
Ran 247 of 805 Specs in 2574.200 seconds
FAIL! -- 235 Passed | 12 Failed | 5 Pending | 553 Skipped

I'm opening this issue to keep track of failures and request help when failures are in Origin itself. Can anybody review the failures and let me know if it's a CRI-O issue or Origin defaulting to use Docker?

@runcom
Copy link
Member Author

runcom commented Sep 18, 2017

@runcom
Copy link
Member Author

runcom commented Sep 18, 2017

FIXED Seccomp test is being fixed here: cri-o/cri-o@52bee06

[Fail] [k8s.io] Security Context [Feature:SecurityContext] [It] should support seccomp alpha docker/default annotation [Feature:Seccomp]
/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/util.go:2224

The following test is also an expected error with CRI-O (kubernetes/kubernetes#44976):

[Fail] [k8s.io] Projected [It] should project all components that make up the projection API [Conformance] [Volume] [Projection]
/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/util.go:2224

FIXED The following is being fixed by #16408 (not a CRI-O failure per-se):

[Fail] [security] supplemental groups [Conformance]Ensure supplemental groups propagate to docker [It] should propagate requested groups to the docker host config [local]
/go/src/github.com/openshift/origin/test/extended/security/supplemental_groups.go:66

We're down to 9 failures

@bparees
Copy link
Contributor

bparees commented Sep 18, 2017

I wouldn't expect any build tests to work until this is resolved: https://trello.com/c/tEWeHyJL

@runcom runcom changed the title CRI-O integration CRI-O integration [9 failures] Sep 19, 2017
@runcom
Copy link
Member Author

runcom commented Sep 20, 2017

[Fail] [k8s.io] StatefulSet [k8s.io] Basic StatefulSet functionality [StatefulSetBasic] [It] Should recreate evicted statefulset
/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/statefulset.go:820

The test above is working fine on my local F26 VM, I think it's a network issue with port mappings and container not being able to come up in time. /cc @dcbw

@bparees
Copy link
Contributor

bparees commented Sep 21, 2017

this should resolve build failures on crio:
#16491

@bparees bparees removed their assignment Oct 9, 2017
@smarterclayton
Copy link
Contributor

Is this done?

@runcom
Copy link
Member Author

runcom commented Oct 23, 2017

Not yet, we're running tests against a origin+cri-o cluster still

@runcom
Copy link
Member Author

runcom commented Oct 30, 2017

[Fail] [Feature:Builds][Conformance] oc new-app  [It] should succeed with a --name of 58 characters [Suite:openshift/conformance/parallel] 
/go/src/github.com/openshift/origin/test/extended/builds/new_app.go:55

[Fail] [Conformance][templates] templateservicebroker end-to-end test  [It] should pass an end-to-end test [Suite:openshift/conformance/parallel] 
/go/src/github.com/openshift/origin/test/extended/templates/templateservicebroker_e2e.go:119

[Fail] [Feature:Builds][Conformance] s2i build with a root user image  [It] should create a root build and pass with a privileged SCC [Suite:openshift/conformance/parallel] 
/go/src/github.com/openshift/origin/test/extended/builds/s2i_root.go:91

[Fail] [Feature:Builds][Conformance][valueFrom] process valueFrom in build strategy environment variables  [It] should successfully resolve valueFrom in s2i build environment variables [Suite:openshift/conformance/parallel] 
/go/src/github.com/openshift/origin/test/extended/builds/valuefrom.go:66

[Fail] [Conformance][templates] templateservicebroker bind test [It] should pass bind tests [Suite:openshift/conformance/parallel] 
/go/src/github.com/openshift/origin/test/extended/templates/templateservicebroker_bind.go:111

[Fail] [Feature:Builds][Conformance] build without output image  building from templates [It] should create an image from a S2i template without an output image reference defined [Suite:openshift/conformance/parallel] 
/go/src/github.com/openshift/origin/test/extended/builds/no_outputname.go:54

[Fail] [Conformance][templates] templateinstance readiness test  [It] should report ready soon after all annotated objects are ready [Suite:openshift/conformance/parallel] 
/go/src/github.com/openshift/origin/test/extended/templates/templateinstance_readiness.go:165

[Fail] [Feature:Builds][Conformance] s2i build with a quota  Building from a template [It] should create an s2i build with a quota and run it [Suite:openshift/conformance/parallel] 
/go/src/github.com/openshift/origin/test/extended/builds/s2i_quota.go:51

[Fail] [Feature:Builds] Optimized image builds  [It] should succeed [Conformance] [Suite:openshift/conformance/parallel] 
/go/src/github.com/openshift/origin/test/extended/builds/optimized.go:69

[Fail] [Conformance][templates] templateservicebroker security test  [It] should pass security tests [Suite:openshift/conformance/parallel] 
/go/src/github.com/openshift/origin/test/extended/templates/templateservicebroker_security.go:97

We do still have some test failing in the OpenShift + CRI-O CI. @bparees @smarterclayton it seems that service broker and images releated tests are failing. Could you help us on that?

/cc @mrunalp

openshift-merge-robot added a commit that referenced this issue Oct 30, 2017
Automatic merge from submit-queue.

test: extended: avoid using docker directly

This test fails when running against CRI-O (https://ci.openshift.redhat.com/jenkins/job/test_branch_origin_extended_conformance_crio/40/console) because it uses docker.

Modify the test to check groups in container instead.

ref #16403
@smarterclayton PTAL

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@bparees
Copy link
Contributor

bparees commented Oct 30, 2017

@runcom from what you pasted it looks to me more like everything that needs a build is failing.

possibly related to https://bugzilla.redhat.com/show_bug.cgi?id=1507424 ?

Have you looked at the logs for the failing builds?

@runcom
Copy link
Member Author

runcom commented Oct 30, 2017

Have you looked at the logs for the failing builds?

I haven't yet, but could be definitely related to that BZ

@runcom
Copy link
Member Author

runcom commented Oct 31, 2017

@pmorie could you help us on the templateservicebroker tests failure?

@runcom
Copy link
Member Author

runcom commented Nov 21, 2017

Builds failures have been fixed (there's a pending PR still). We have 3 templateservicebroker tests failures remaining

@runcom
Copy link
Member Author

runcom commented Dec 16, 2017

We got to 0 here so closing!

@runcom runcom closed this as completed Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants