Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: extended: avoid using docker directly #16408

Merged
merged 1 commit into from
Oct 30, 2017
Merged

test: extended: avoid using docker directly #16408

merged 1 commit into from
Oct 30, 2017

Conversation

runcom
Copy link
Member

@runcom runcom commented Sep 18, 2017

This test fails when running against CRI-O (https://ci.openshift.redhat.com/jenkins/job/test_branch_origin_extended_conformance_crio/40/console) because it uses docker.

Modify the test to check groups in container instead.

ref #16403
@smarterclayton PTAL

Signed-off-by: Antonio Murdaca runcom@redhat.com

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 18, 2017
@runcom runcom mentioned this pull request Sep 18, 2017
Closed
@runcom
Copy link
Member Author

runcom commented Sep 18, 2017

can we also trigger tests with CRI-O on this /cc @Kargakis

@0xmichalis
Copy link
Contributor

/test crio

@runcom
Copy link
Member Author

runcom commented Sep 18, 2017 •
edited
Loading

/test crio

we need this though openshift-eng/aos-cd-jobs#640 (sorry)

@0xmichalis
Copy link
Contributor

/test crio

@runcom
Copy link
Member Author

runcom commented Sep 18, 2017

ci/openshift-jenkins/extended_conformance_crio

@Kargakis , failure in crio (not sure it's related to crio, is it?)

"msg": "No package matching 'origin-3.7.0-0.alpha.1.452.62b50ee' found available, installed or updated",

smarterclayton
smarterclayton reviewed Sep 18, 2017
View reviewed changes
test/extended/security/supplemental_groups.go Outdated
)

var _ = g.Describe("[security] supplemental groups", func() {
defer g.GinkgoRecover()

const (
supplementaGroupsPod = "supplemental-groups"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@smarterclayton
Copy link
Contributor

One minor nit but otherwise looks good.

@runcom
Copy link
Member Author

runcom commented Sep 18, 2017

@Kargakis @stevekuznetsov I suspect the CRI-O test fails because we're not building any release RPM in the crio job file, we may need something like this in the CRI-O job? https://github.com/openshift/aos-cd-jobs/blob/master/sjb/config/test_cases/test_branch_origin_extended_conformance_install.yml#L11-L35

@stevekuznetsov
Copy link
Contributor

Yeah @Kargakis the pull request job shouldn't be on the build image stage and needs to build itself.

@0xmichalis
Copy link
Contributor

/test crio

@runcom runcom force-pushed the fix-test-no-docker branch 10 times, most recently from eb55620 to f672d5d Compare September 19, 2017 11:23
@runcom
test: extended: avoid using docker directly
356a379 
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@runcom
Copy link
Member Author

runcom commented Sep 19, 2017

/test crio

@runcom
Copy link
Member Author

runcom commented Sep 19, 2017

@smarterclayton the 11 failures in crio tests are known and tracked by #16403 - this is good to merge as it's actually fixing one the failing tests in #16403

@runcom
Copy link
Member Author

runcom commented Sep 28, 2017

/test crio

@runcom
Copy link
Member Author

runcom commented Oct 26, 2017

/test crio

@runcom
Copy link
Member Author

runcom commented Oct 29, 2017

@smarterclayton can you guys merge this? the test is passing but crio CI is failing because of other tests failing.

@smarterclayton
Copy link
Contributor

/lgtm
/kind bug

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. kind/bug Categorizes issue or PR as related to a bug. labels Oct 29, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom, smarterclayton

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2017
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 30, 2017 •
edited
Loading

@runcom: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_crio 356a379 link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit f2a47df into openshift:master Oct 30, 2017
@runcom runcom deleted the fix-test-no-docker branch October 30, 2017 11:16
@atiratree atiratree mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton smarterclayton left review comments

Assignees

@mfojtik mfojtik

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@runcom @0xmichalis @smarterclayton @stevekuznetsov @openshift-merge-robot @openshift-bot @openshift-ci-robot @mfojtik