test using osc project to change contexts #1599

deads2k · 2015-04-06T13:56:47Z

Looks like @smarterclayton fixed this as a side effect of: #1566.

deads2k · 2015-04-06T13:56:52Z

[test]

openshift-bot · 2015-04-06T14:00:40Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1741/)

deads2k · 2015-04-06T15:01:57Z

@liggitt router failed (transient?), but the switch worked correctly:

[INFO] Back to 'master' context with 'admin' user...
Now using project "master" from context named "master-0" on server "https://10.171.67.218:8443".

smarterclayton · 2015-04-06T15:06:59Z

Good. Let's reestablish then fabiano?

----- Original Message -----

@liggitt router failed (transient?), but the switch worked correctly:
[INFO] Back to 'master' context with 'admin' user...
Now using project "master" from context named "master-0" on server
"https://10.171.67.218:8443".
Reply to this email directly or view it on GitHub:
#1599 (comment)

smarterclayton · 2015-04-06T15:07:05Z

Nm, david had it.

deads2k · 2015-04-07T17:13:02Z

@liggitt updates after the cli meeting. osadm create-kubeconfig now sets a namespace.

deads2k · 2015-04-08T11:52:22Z

Updated to use proper constant.

liggitt · 2015-04-08T15:05:24Z

hack/test-end-to-end.sh

@@ -328,6 +313,9 @@ wait_for_app "test"

 # ensure the router is started
 # TODO: simplify when #4702 is fixed upstream
+echo "[INFO] Back to 'master' context with 'admin' user..."
+osc project default


the switch back to cluster admin was above wait_for_build so that build-logs would work. Looks like .Stream() never returns an error if the request completes, regardless of http status code

Yeah, stream should error on non 200. Yuck.

----- Original Message -----

@@ -328,6 +313,9 @@ wait_for_app "test"

ensure the router is started

TODO: simplify when #4702 is fixed upstream

+echo "[INFO] Back to 'master' context with 'admin' user..."
+osc project default

the switch back to cluster admin was above wait_for_build so that build-logs
would work. Looks like .Stream() never returns an error if the request
completes, regardless of http status code

Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1599/files#r27978324

deads2k · 2015-04-08T17:04:37Z

Upstream issue here: kubernetes/kubernetes#6579

liggitt · 2015-04-08T17:29:48Z

pkg/cmd/server/admin/create_kubeconfig.go

@@ -111,6 +124,9 @@ func (o CreateKubeConfigOptions) Validate(args []string) error {
 	if len(o.UserNick) == 0 {
 		return errors.New("user-nick must be provided")
 	}
+	if len(o.ContextNamespace) == 0 {


required from the command line, but defaults when composed from another command?

liggitt · 2015-04-08T17:33:40Z

LGTM

deads2k · 2015-04-08T17:37:38Z

[merge]

openshift-bot · 2015-04-08T21:11:01Z

Evaluated for origin up to 36dc5b6

openshift-bot · 2015-04-08T21:11:11Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1741/) (Image: devenv-fedora_1235)

…ontext Merged by openshift-bot

…service-catalog/' changes from d969acde90..b69b4a6c80 b69b4a6c80 origin build: modify hard coded path 527fac4d02 origin build: add origin tooling 545ffdb chart changes for v0.1.5 release (openshift#1709) 4d9be8f Use userInfo for Originating-Identity so extras is correct. (openshift#1702) f358b99 Call destroy function on each storage interface (openshift#1705) 36b5de9 refactor binding reconciliation functions (openshift#1687) 5699360 Change binding_retrievable to bindingRetrievable 0d8bcfe thread through stopCh to DestroyFunc (openshift#1671) 1c45aef Migrate from glide to dep for dependency management (openshift#1670) 1cf0dd9 Add svcat to Makefile (openshift#1683) 45b1013 make verify validates that versioned APIs contain json tags for fields, addresses openshift#1303 (openshift#1480) 0ee8398 Build the integration test binary before running any tests (openshift#1666) 0fe0aa7 Update design.md (openshift#1674) 1280d24 controller requires permission to update secrets (openshift#1663) 129d98e Contribute svcat (openshift#1664) ff9739b Update dependencies to kubernetes-1.9.1 (openshift#1633) 9c36019 chart changes for v0.1.4 release (openshift#1669) 93319f6 move apiserver generation to script and verify (openshift#1662) 385f0da refactor service instance provision/update/poll reconciliation (openshift#1648) e015212 run each integration test individually (openshift#1661) 412e242 Tell people whether we're checking external hrefs (openshift#1659) ae05361 retry failed unbind requests (openshift#1653) 7eae845 doc for setting up Service Catalog with Prometheus metrics (openshift#1654) 0720cf9 minor README copy edit (openshift#1656) 8bd347d run some integration subtests in parallel (openshift#1637) b83800c Use $ and console to indicate multi-command blocks 789c4b2 Use dynamic reaction to fix data race (openshift#1650) f1be763 only check external hrefs on master (openshift#1652) 65c6d20 Controller-manager crash loops if API server is not available on startup (openshift#1376) (openshift#1591) 9225c92 embedded etcd is the way of the future for our tests (openshift#1651) 605c952 Fix required fields in OpenAPI schema (openshift#1602) 899ca21 Revert "Switch to wget for integration apiserver checks (openshift#1384)" (openshift#1585) 2f496ee Update code-of-conduct.md (openshift#1635) c1c69cf Build the e2e binary in CI (openshift#1647) 4e2dcef Wait for successful API discovery (openshift#1646) 5ae6d99 Bump copyright date in generated code (openshift#1645) 8be5b05 Serve OpenAPI spec only when --serve-openapi-spec switch is enabled (openshift#1612) 19fb30e silence go-restful logging output (openshift#1622) fdbabf0 Add walkthrough link back (openshift#1620) 7c73e9a Add link to main k8s docs on service-catalog (openshift#1627) f59adc9 Overhauling the design document (openshift#1619) cd7b633 Updating the install documentation (openshift#1616) f6e5441 fix compilation error from updated util.WaitForBindingCondition() (openshift#1629) (openshift#1631) 54e57af Provide OSB Client proxy to instrument with metrics (openshift#1615) 026b86f Disable test added in 1611 that contains data race (openshift#1626) cb735a6 Add integration tests for ServiceInstances (openshift#1611) 67dbabb Cleaning up the docs README (openshift#1618) 6bddc07 remove email from docker login during Travis deploy (openshift#1614) a604bc3 Use ConfigMaps for leader election (openshift#1599) c6f193a Add controller integration tests for ServiceInstance create and update (openshift#1578) 26cf23b Rename OWNERS assignees: to approvers: (openshift#1508) 1163edc expose Prometheus metrics from Controller (openshift#677) (openshift#1608) 2cd6554 Clean up docs/ folder (openshift#1609) 1d7e96d Adding Service Binding Create Integration Tests (openshift#1580) 6a4c469 Make the maximum polling backoff configurable (openshift#1607) 31bbf55 Rename the imported package to avoid name conflict (openshift#1603) 3cdd556 Add validation for broker spec to SAR admission controller (openshift#1605) a3408ce fix docker volume mount when building with docker under SELinux (openshift#1500) (openshift#1534) 307e747 Remove unneeded vendors of vendors (openshift#1596) 770fc74 Make ups-instance.yaml in walkthrough to demonstrate good practices (openshift#1592) 9112ba1 Add links to docs/README (openshift#1589) 8902648 Add additional service to ups-broker to fix e2e (openshift#1583) 0bcbc7d move instance update logic out of reconcileServiceInstanceDelete (openshift#1584) 7ef5a3e Do not send Parameters field when there are no parameters from sourced secret (openshift#1559) 4c51b25 Remove unneeded code that sets reason for provision/update call failure (openshift#1561) b122cb9 fix bind injection failure not being persisted in API server (openshift#1546) 66421d5 Clear out current operation when starting reconciliation of a delete (openshift#1564) 8cca70a Send an empty object for Parameters when deleting all parameters of a ServiceInstance (openshift#1555) 270426c Add controllerTest type as a helper for running controller integration tests. (openshift#1577) e26c2d7 Ignore .vscode folder in project root (openshift#1579) REVERT: d969acde90 Add additional service to ups-broker to fix e2e (openshift#1583) REVERT: 1bcd53b684 origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: b69b4a6c8003f25d040e3087c7b1b16d1854a9e9

deads2k force-pushed the deads-allow-project-to-change-context branch 2 times, most recently from 2fc214c to d284d04 Compare April 7, 2015 17:12

deads2k force-pushed the deads-allow-project-to-change-context branch from d284d04 to 8521956 Compare April 8, 2015 11:52

liggitt reviewed Apr 8, 2015
View reviewed changes

deads2k force-pushed the deads-allow-project-to-change-context branch from 8521956 to 951e969 Compare April 8, 2015 17:01

liggitt reviewed Apr 8, 2015
View reviewed changes

deads2k added 3 commits April 8, 2015 13:35

set context namespace in generated .kubeconfig

ba84902

Test switching contexts with osc project

10a7372

UPSTREAM: make .Stream handle error status codes

36dc5b6

deads2k force-pushed the deads-allow-project-to-change-context branch from 951e969 to 36dc5b6 Compare April 8, 2015 17:35

openshift-bot pushed a commit that referenced this pull request Apr 8, 2015

Merge pull request #1599 from deads2k/deads-allow-project-to-change-c…

8bb84aa

…ontext Merged by openshift-bot

openshift-bot merged commit 8bb84aa into openshift:master Apr 8, 2015

deads2k deleted the deads-allow-project-to-change-context branch April 9, 2015 12:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test using osc project to change contexts #1599

test using osc project to change contexts #1599

deads2k commented Apr 6, 2015

deads2k commented Apr 6, 2015

openshift-bot commented Apr 6, 2015

deads2k commented Apr 6, 2015

smarterclayton commented Apr 6, 2015

smarterclayton commented Apr 6, 2015

deads2k commented Apr 7, 2015

deads2k commented Apr 8, 2015

liggitt Apr 8, 2015

smarterclayton Apr 8, 2015

deads2k commented Apr 8, 2015

liggitt Apr 8, 2015

liggitt commented Apr 8, 2015

deads2k commented Apr 8, 2015

openshift-bot commented Apr 8, 2015

openshift-bot commented Apr 8, 2015

test using osc project to change contexts #1599

test using osc project to change contexts #1599

Conversation

deads2k commented Apr 6, 2015

deads2k commented Apr 6, 2015

openshift-bot commented Apr 6, 2015

deads2k commented Apr 6, 2015

smarterclayton commented Apr 6, 2015

smarterclayton commented Apr 6, 2015

deads2k commented Apr 7, 2015

deads2k commented Apr 8, 2015

liggitt Apr 8, 2015

Choose a reason for hiding this comment

smarterclayton Apr 8, 2015

Choose a reason for hiding this comment

ensure the router is started

TODO: simplify when #4702 is fixed upstream

deads2k commented Apr 8, 2015

liggitt Apr 8, 2015

Choose a reason for hiding this comment

liggitt commented Apr 8, 2015

deads2k commented Apr 8, 2015

openshift-bot commented Apr 8, 2015

openshift-bot commented Apr 8, 2015