Make hack/build-go.sh create symlinks for openshift #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
@smarterclayton plz review |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/755/) |
|
Kicked travis |
| if [[ -f "${OS_OUTPUT_BINPATH}/${platform}/openshift" ]]; then | ||
| echo "++ Creating symlinks" | ||
| for linkname in "${OPENSHIFT_BINARY_SYMLINKS[@]}"; do | ||
| ln -s "${OS_OUTPUT_BINPATH}/${platform}/openshift" "${OS_OUTPUT_BINPATH}/${platform}/${linkname}" |
There was a problem hiding this comment.
Is this going to make them properly absolute? It might not matter, just want to check
There was a problem hiding this comment.
@smarterclayton It will:
$ ls -l _output/local/bin/linux/amd64/
total 38740
-rwxr-xr-x. 1 pmorie 39643392 Jan 19 17:55 openshift
lrwxrwxrwx. 1 pmorie 64 Jan 19 18:10 openshift-deploy -> /home/pmorie/code/origin/_output/local/bin/linux/amd64/openshift
lrwxrwxrwx. 1 pmorie 64 Jan 19 18:10 openshift-docker-build -> /home/pmorie/code/origin/_output/local/bin/linux/amd64/openshift
lrwxrwxrwx. 1 pmorie 64 Jan 19 18:10 openshift-experimental -> /home/pmorie/code/origin/_output/local/bin/linux/amd64/openshift
lrwxrwxrwx. 1 pmorie 64 Jan 19 18:10 openshift-router -> /home/pmorie/code/origin/_output/local/bin/linux/amd64/openshift
lrwxrwxrwx. 1 pmorie 64 Jan 19 18:10 openshift-sti-build -> /home/pmorie/code/origin/_output/local/bin/linux/amd64/openshift
lrwxrwxrwx. 1 pmorie 64 Jan 19 18:10 osc -> /home/pmorie/code/origin/_output/local/bin/linux/amd64/openshift
|
Can you remove the symlink creation from test-end-to-end (and test-cmd if it's there?) |
|
@smarterclayton I can do anything if I put my mind to it, man. |
pmorie
force-pushed
the
build
branch
4 times, most recently
from
8aed347
to
10fec57
Compare
|
@smarterclayton addressed |
|
@smarterclayton The release image will need to be rebuilt in order for travis/jenkins to pass. |
|
@smarterclayton, disregard last comment. The problem in travis is that the symlink hasn't been created. I think we will need to lazily create the symlink if it doesn't exist. |
|
Yes, I tried to send that email last night but it got caught in my queue. |
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/635/) (Image: devenv-fedora_558) |
|
Evaluated for origin up to 25328c4 |
|
Oh, then leave it in the hack/test-cmd and end to end tests. Since we can be backwards compat.
|
|
@smarterclayton I was wrong about the images. |
openshift-bot
pushed a commit
that referenced
this pull request
Jan 20, 2015
Merged by openshift-bot
|
Fix |
sjenning
pushed a commit
to sjenning/origin
that referenced
this pull request
Jan 5, 2018
…ect-3.5 Merged by openshift-bot
jboyd01
pushed a commit
to jboyd01/origin
that referenced
this pull request
Feb 6, 2018
…service-catalog/' changes from d969acde90..b69b4a6c80 b69b4a6c80 origin build: modify hard coded path 527fac4d02 origin build: add origin tooling 545ffdb chart changes for v0.1.5 release (openshift#1709) 4d9be8f Use userInfo for Originating-Identity so extras is correct. (openshift#1702) f358b99 Call destroy function on each storage interface (openshift#1705) 36b5de9 refactor binding reconciliation functions (openshift#1687) 5699360 Change binding_retrievable to bindingRetrievable 0d8bcfe thread through stopCh to DestroyFunc (openshift#1671) 1c45aef Migrate from glide to dep for dependency management (openshift#1670) 1cf0dd9 Add svcat to Makefile (openshift#1683) 45b1013 make verify validates that versioned APIs contain json tags for fields, addresses openshift#1303 (openshift#1480) 0ee8398 Build the integration test binary before running any tests (openshift#1666) 0fe0aa7 Update design.md (openshift#1674) 1280d24 controller requires permission to update secrets (openshift#1663) 129d98e Contribute svcat (openshift#1664) ff9739b Update dependencies to kubernetes-1.9.1 (openshift#1633) 9c36019 chart changes for v0.1.4 release (openshift#1669) 93319f6 move apiserver generation to script and verify (openshift#1662) 385f0da refactor service instance provision/update/poll reconciliation (openshift#1648) e015212 run each integration test individually (openshift#1661) 412e242 Tell people whether we're checking external hrefs (openshift#1659) ae05361 retry failed unbind requests (openshift#1653) 7eae845 doc for setting up Service Catalog with Prometheus metrics (openshift#1654) 0720cf9 minor README copy edit (openshift#1656) 8bd347d run some integration subtests in parallel (openshift#1637) b83800c Use $ and console to indicate multi-command blocks 789c4b2 Use dynamic reaction to fix data race (openshift#1650) f1be763 only check external hrefs on master (openshift#1652) 65c6d20 Controller-manager crash loops if API server is not available on startup (openshift#1376) (openshift#1591) 9225c92 embedded etcd is the way of the future for our tests (openshift#1651) 605c952 Fix required fields in OpenAPI schema (openshift#1602) 899ca21 Revert "Switch to wget for integration apiserver checks (openshift#1384)" (openshift#1585) 2f496ee Update code-of-conduct.md (openshift#1635) c1c69cf Build the e2e binary in CI (openshift#1647) 4e2dcef Wait for successful API discovery (openshift#1646) 5ae6d99 Bump copyright date in generated code (openshift#1645) 8be5b05 Serve OpenAPI spec only when --serve-openapi-spec switch is enabled (openshift#1612) 19fb30e silence go-restful logging output (openshift#1622) fdbabf0 Add walkthrough link back (openshift#1620) 7c73e9a Add link to main k8s docs on service-catalog (openshift#1627) f59adc9 Overhauling the design document (openshift#1619) cd7b633 Updating the install documentation (openshift#1616) f6e5441 fix compilation error from updated util.WaitForBindingCondition() (openshift#1629) (openshift#1631) 54e57af Provide OSB Client proxy to instrument with metrics (openshift#1615) 026b86f Disable test added in 1611 that contains data race (openshift#1626) cb735a6 Add integration tests for ServiceInstances (openshift#1611) 67dbabb Cleaning up the docs README (openshift#1618) 6bddc07 remove email from docker login during Travis deploy (openshift#1614) a604bc3 Use ConfigMaps for leader election (openshift#1599) c6f193a Add controller integration tests for ServiceInstance create and update (openshift#1578) 26cf23b Rename OWNERS assignees: to approvers: (openshift#1508) 1163edc expose Prometheus metrics from Controller (openshift#677) (openshift#1608) 2cd6554 Clean up docs/ folder (openshift#1609) 1d7e96d Adding Service Binding Create Integration Tests (openshift#1580) 6a4c469 Make the maximum polling backoff configurable (openshift#1607) 31bbf55 Rename the imported package to avoid name conflict (openshift#1603) 3cdd556 Add validation for broker spec to SAR admission controller (openshift#1605) a3408ce fix docker volume mount when building with docker under SELinux (openshift#1500) (openshift#1534) 307e747 Remove unneeded vendors of vendors (openshift#1596) 770fc74 Make ups-instance.yaml in walkthrough to demonstrate good practices (openshift#1592) 9112ba1 Add links to docs/README (openshift#1589) 8902648 Add additional service to ups-broker to fix e2e (openshift#1583) 0bcbc7d move instance update logic out of reconcileServiceInstanceDelete (openshift#1584) 7ef5a3e Do not send Parameters field when there are no parameters from sourced secret (openshift#1559) 4c51b25 Remove unneeded code that sets reason for provision/update call failure (openshift#1561) b122cb9 fix bind injection failure not being persisted in API server (openshift#1546) 66421d5 Clear out current operation when starting reconciliation of a delete (openshift#1564) 8cca70a Send an empty object for Parameters when deleting all parameters of a ServiceInstance (openshift#1555) 270426c Add controllerTest type as a helper for running controller integration tests. (openshift#1577) e26c2d7 Ignore .vscode folder in project root (openshift#1579) REVERT: d969acde90 Add additional service to ups-broker to fix e2e (openshift#1583) REVERT: 1bcd53b684 origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: b69b4a6c8003f25d040e3087c7b1b16d1854a9e9
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.