Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 53233: Remove containers from deleted pods once containers have exited #16914

Closed
wants to merge 3 commits into from

Conversation

joelsmith
Copy link
Contributor

UPSTREAM: 53233: Remove containers from deleted pods once containers have exited
which needed
UPSTREAM: 47316: Added golint check for pkg/kubelet.
to cleanly apply.

Note to reviewer: This is definitely one that is easier to review as separate commits

xref kubernetes/kubernetes#53233
xref kubernetes/kubernetes#47316

NOTE: There is an alternate version of this PR without the golint commit:
#16913
we need to decide which is the better version.

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joelsmith
We suggest the following additional approver: deads2k

Assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Oct 17, 2017
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2017
@joelsmith
Copy link
Contributor Author

/kind bug
/unassign @liggitt
/unassign @deads2k
/assign @derekwaynecarr

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 17, 2017
@joelsmith joelsmith added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2017
@liggitt
Copy link
Contributor

liggitt commented Oct 17, 2017

strongly prefer #16913

@joelsmith
Copy link
Contributor Author

closing in favor of #16913

@joelsmith joelsmith closed this Oct 17, 2017
@joelsmith joelsmith deleted the pick-53233 branch October 17, 2017 19:46
@openshift-ci-robot
Copy link

@joelsmith: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/unit b5d7d25 link /test unit
ci/openshift-jenkins/extended_conformance_install_update b5d7d25 link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants