Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 53233: Remove containers from deleted pods once containers have exited #16913

Merged
merged 1 commit into from
Oct 18, 2017
Merged

UPSTREAM: 53233: Remove containers from deleted pods once containers have exited #16913

merged 1 commit into from
Oct 18, 2017

Conversation

joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Oct 17, 2017 •
edited
Loading

xref kubernetes/kubernetes#53233

Note: I had to edit podId to podID to make it apply cleanly.

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Oct 17, 2017
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2017
@joelsmith joelsmith mentioned this pull request Oct 17, 2017
Closed
@joelsmith
Copy link
Contributor Author

/kind bug
/unassign @smarterclayton
/unassign @deads2k
/assign @derekwaynecarr

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 17, 2017
@joelsmith joelsmith added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed kind/bug Categorizes issue or PR as related to a bug. labels Oct 17, 2017
@liggitt
Copy link
Contributor

liggitt commented Oct 17, 2017

@derekwaynecarr were you expecting kubernetes/kubernetes#50350 as well or is this orthogonal?

@joelsmith joelsmith removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2017
@derekwaynecarr
Copy link
Member

@liggitt that went in as part of #16865

/approve no-issue
/lgtm

open same for openshift:stage

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, joelsmith

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2017
@joelsmith joelsmith mentioned this pull request Oct 17, 2017
Closed
@joelsmith joelsmith added the kind/bug Categorizes issue or PR as related to a bug. label Oct 17, 2017
@joelsmith
Copy link
Contributor Author

/test extended_conformance_gce

@liggitt
Copy link
Contributor

liggitt commented Oct 17, 2017

@liggitt that went in as part of #16865

ah, hadn't pulled latest master

@joelsmith
Copy link
Contributor Author

/retest

1 similar comment
@joelsmith
Copy link
Contributor Author

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16888, 16911, 16913, 16904).

@openshift-merge-robot openshift-merge-robot merged commit 9bb5db6 into openshift:master Oct 18, 2017
@smarterclayton smarterclayton mentioned this pull request Oct 19, 2017
Closed
@sjenning sjenning mentioned this pull request Oct 24, 2017
Closed
@joelsmith joelsmith deleted the pick-53233-alt branch February 12, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@joelsmith @liggitt @derekwaynecarr @openshift-merge-robot @smarterclayton @deads2k @openshift-ci-robot