Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stage] UPSTREAM: 53233: Remove containers from deleted pods once containers have exited #16915

Closed
wants to merge 19 commits into from
Closed

[stage] UPSTREAM: 53233: Remove containers from deleted pods once containers have exited #16915

wants to merge 19 commits into from

Conversation

joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Oct 17, 2017 •
edited

This is a pick to stage of #16913

deads2k and others added 19 commits October 5, 2017 14:56
@deads2k
switch build logs to use client, not storage
4c00a82
@openshift-merge-robot
Merge pull request openshift#16707 from deads2k/build-07-client-stage
d45d544 
Automatic merge from submit-queue.

switch build logs to use client, not storage

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1499016

stage pick of openshift#16705

/assign bparees
/assign jupierce

did I get the right spot?  What's the bugzilla number?
@gabemontero
fix select error handling after WaitForRunningBuild
d451548
@openshift-merge-robot
Merge pull request openshift#16738 from gabemontero/fix-bcinstantiate…
b728e02 
…-panic-stage

Automatic merge from submit-queue.

fix select error handling after WaitForRunningBuild

see openshift#16736 but for stage branch

@bparees
@sjenning @derekwaynecarr
UPSTREAM: 53446: kubelet: add latency metrics to network plugin manager
7e8520f
@openshift-merge-robot @knobunc
Merge pull request openshift#16692 from dcbw/sdn-sync-hostports-less
b5abfaf 
Automatic merge from submit-queue (batch tested with PRs 16741, 16692).

sdn: only sync HostPorts when we need to

Which is the first time a pod is started, when there will be active hostports, or when there are current active hostports.  Otherwise the syncer runs iptables-restore for no good reason.

@openshift/networking @knobunc @danwinship
@eparis
Merge pull request openshift#16813 from derekwaynecarr/metric-stage
52edfa1 
UPSTREAM: 53446: kubelet: add latency metrics to network plugin manager
@eparis
Merge pull request openshift#16814 from knobunc/pick/pr16692-dont-ipt…
0551026 
…ables-when-no-hostport

sdn: only sync HostPorts when we need to (backport to stage)
@sjenning
clusterresourceoverride: exempt known infra projects from enforcement
412542b
@sjenning @joelsmith
UPSTREAM: google/cadvisor: 1766: adaptive longOp for du operation
431e633
@joelsmith
UPSTREAM: 53753: Reduce log spam in qos container manager
1f1c4fe
@eparis
Merge pull request openshift#16856 from joelsmith/stage
c5491d6 
UPSTREAM: 53753: Reduce log spam in qos container manager
@eparis
Merge pull request openshift#16851 from sjenning/pick-16845-stage
90db4bb 
clusterresourceoverride: exempt known infra projects from enforcement
@eparis
Merge pull request openshift#16855 from joelsmith/pick-cadv-1766
0ec7b74 
UPSTREAM: google/cadvisor: 1766: adaptive longOp for du operation
disable tsb extended testing on gce
cc708d4
@enj
Make admin project creation wait for SAR
d897e74 
This change adds a SAR check to direct project creation to ensure
that the designated user can get the project which was created for
them.  It also updates the project integration tests to be more
tolerant of the project ACL being out of date.  This race condition
became more apparent as we moved to the generated clients since
those clients were smaller and had their own rate limiters (instead
of a one big client that could do everything and shared the same
rate limiter).  Since the new clients would perform actions at a
faster pace, the race against the project ACL would occur more
frequently.

Signed-off-by: Monis Khan <mkhan@redhat.com>
@enj
Merge pull request openshift#16887 from jim-minter/stage-tsb-gce
962ddd5 
disable tsb extended testing on gce
@openshift-merge-robot
Merge pull request openshift#16891 from enj/automated-cherry-pick-of-…
71e69d4 
…#16849-upstream-stage

Automatic merge from submit-queue.

Automated cherry pick of openshift#16849

Cherry pick of openshift#16849 on stage.

openshift#16849: Make admin project creation wait for SAR
@joelsmith
UPSTREAM: 53233: Remove containers from deleted pods once containers …
5862447 
…have exited
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Oct 17, 2017
@joelsmith joelsmith added the kind/bug Categorizes issue or PR as related to a bug. label Oct 17, 2017
@joelsmith
Copy link
Contributor Author

/assign @derekwaynecarr
/unassign @bparees
/unassign @deads2k

@derekwaynecarr
Copy link
Member

/approve no-issue
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2017
@0xmichalis
Copy link
Contributor

/retest

3 similar comments
@joelsmith
Copy link
Contributor Author

/retest

@joelsmith
Copy link
Contributor Author

/retest

@0xmichalis
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@0xmichalis
Copy link
Contributor

flaked on #16994

/retest

@0xmichalis
Copy link
Contributor

/test all

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@joelsmith
Copy link
Contributor Author

/test extended_conformance_gce

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

@joelsmith: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 5862447 link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install_update 5862447 link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

@joelsmith PR needs rebase

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2017
@sjenning
Copy link
Contributor

stage has been recut. this change will come in from master.

@sjenning sjenning closed this Oct 25, 2017
@joelsmith joelsmith deleted the pick-53233 branch February 12, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet