-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: Rename Dockerfile #500
NO-JIRA: Rename Dockerfile #500
Conversation
0fb62cd
to
4a95ea8
Compare
this will be auto merged to 4.17 and 4.18, so need additional changes in openshift/release#54075 |
@ashwindasr: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashwindasr, jzding The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@ashwindasr: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ptp-operator-must-gather-container-v4.17.0-202407100011.p0.gc60f691.assembly.stream.el9 for distgit ptp-operator-must-gather. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-ptp-operator-container-v4.17.0-202407100011.p0.gc60f691.assembly.stream.el9 for distgit ptp-operator. |
Refactor name to
Dockerfile.ocp
as a better, version independent, alternative since contents are actually rhel9.CI: openshift/release#54075 (probably needs to merge first)
Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.