Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ptp-operator] Rename dockerfiles #54075

Conversation

ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Jul 5, 2024

For openshift/ptp-operator#500

Unsure whether additional files need to change here, since two components build out from the same master repo

@ashwindasr ashwindasr force-pushed the ptp-operator-rename-dockerfile branch from d3f502c to 8cf4271 Compare July 5, 2024 18:03
@ashwindasr ashwindasr changed the title [ptp-operator] Rename dockerfile [ptp-operator] Rename dockerfiles Jul 5, 2024
@openshift-ci openshift-ci bot requested review from dougbtv and fedepaol July 5, 2024 18:13
@jzding
Copy link
Contributor

jzding commented Jul 9, 2024

need to change this for 4.17 and 4.18 files too

@ashwindasr ashwindasr force-pushed the ptp-operator-rename-dockerfile branch from 8cf4271 to a74fb8c Compare July 9, 2024 16:37
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@ashwindasr: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ptp-operator-master-ci-index openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-master-e2e-aws-ovn openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-master-gofmt openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-master-govet openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-master-images openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-master-operator-e2e openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-master-security openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-release-4.18-ci-index openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-release-4.18-e2e-aws-ovn openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-release-4.18-gofmt openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-release-4.18-govet openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-release-4.18-images openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-release-4.18-operator-e2e openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-release-4.18-security openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-release-4.17-ci-index openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-release-4.17-e2e-aws-ovn openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-release-4.17-gofmt openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-release-4.17-govet openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-release-4.17-images openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-release-4.17-operator-e2e openshift/ptp-operator presubmit Ci-operator config changed
pull-ci-openshift-ptp-operator-release-4.17-security openshift/ptp-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@nishant-parekh
Copy link
Contributor

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@nishant-parekh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@nishant-parekh
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@nishant-parekh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 9, 2024
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

@ashwindasr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/ptp-operator/release-4.17/ci-index a74fb8c link unknown /pj-rehearse pull-ci-openshift-ptp-operator-release-4.17-ci-index
ci/rehearse/openshift/ptp-operator/release-4.17/e2e-aws-ovn a74fb8c link unknown /pj-rehearse pull-ci-openshift-ptp-operator-release-4.17-e2e-aws-ovn
ci/rehearse/openshift/ptp-operator/release-4.17/images a74fb8c link unknown /pj-rehearse pull-ci-openshift-ptp-operator-release-4.17-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5fd0bd7 into openshift:master Jul 9, 2024
17 of 20 checks passed
@ashwindasr ashwindasr deleted the ptp-operator-rename-dockerfile branch July 9, 2024 20:48
ptalgulk01 pushed a commit to ptalgulk01/release that referenced this pull request Jul 10, 2024
jtaleric pushed a commit to jtaleric/release that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants