ci-operator/step-registry/gather/gcp-console: Gather console logs on GCP #13398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
ci-operator/step-registry/gather/gcp-console/gather-gcp-console-commands.sh
Outdated
Show resolved
Hide resolved
ci-operator/step-registry/gather/gcp-console/gather-gcp-console-commands.sh
Outdated
Show resolved
Hide resolved
wking
force-pushed
the
gcp-console-logs
branch
from
64c641c
to
32c3302
Compare
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Dec 16, 2020
Abhinav pointed out that there may be some IDs in the SHARED_DIR file, and when there are, we can gather those even if we lack a kubeconfig to extract additional IDs from within the cluster [1]. [1]: openshift#13398 (comment)
wking
force-pushed
the
gcp-console-logs
branch
2 times, most recently
from
baaf890
to
d4bb001
Compare
Like the similar aws-console step, but for GCP, following [1]. I'm
not sure why they require a --zone argument when 'instances list'
seems to be able to figure this out, but whatever. Leaving it off
doesn't seem to be an option:
wking@cloudshell:~ (openshift-gce-devel-ci)$ gcloud --format json compute instances get-serial-port-output "${INSTANCE_ID}" </dev/null >logs.json
ERROR: (gcloud.compute.instances.get-serial-port-output) Underspecified resource [ci-ln-2gtd6db-f76d1-fj4cl-master-0]. Specify the [--zone] flag.
wking@cloudshell:~ (openshift-gce-devel-ci)$ gcloud --version | head -n1
Google Cloud SDK 315.0.0
OWNERS are like AWS, from 390d6be (gather/aws/console: Add a step
to gather console logs on AWS, 2020-06-17, openshift#9743), and also the
installer's GCP approvers [2].
[1]: https://cloud.google.com/compute/docs/reference/rest/v1/instances/getSerialPortOutput
[2]: https://github.com/openshift/installer/blob/e17697302ff991ae80d6e9c0c10426db510881e2/OWNERS_ALIASES#L60-L62
wking
commented
Dec 17, 2020
ci-operator/step-registry/gather/gcp-console/gather-gcp-console-commands.sh
Outdated
Show resolved
Hide resolved
wking
force-pushed
the
gcp-console-logs
branch
from
d4bb001
to
5d9d973
Compare
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@wking: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I don't think this worked, see errors in this job https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-ocp-installer-e2e-gcp-rt-4.7/1339905732908158976 |
That's an old-style release-template job (no per-step directories here), so this step wasn't involved at all there. But yeah, seems to be having some trouble. See this untrusted API-server after a failed install: And this failure to find a zone after a failed bootstrap: I'll get a fixup up for these cases where the cluster-install had trouble... |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Dec 19, 2020
I'm not quite sure where the empty line came from, but [1] had: 2020/12/19 12:29:58 Executing pod "e2e-gcp-upgrade-gather-gcp-console" 2020/12/19 12:30:03 Container cp-secret-wrapper in pod e2e-gcp-upgrade-gather-gcp-console completed successfully Activated service account credentials for: [do-not-delete-ci-provisioner@openshift-gce-devel-ci.iam.gserviceaccount.com] Updated property [core/project]. Finding the zone for No zone found for , so not attempting to gather console logs Gathering console logs for from ERROR: (gcloud.compute.instances.get-serial-port-output) could not parse resource [] error: failed to execute wrapped command: exit status 1 2020/12/19 12:30:13 Container test in pod e2e-gcp-upgrade-gather-gcp-console failed, exit code 1, reason Error The 'grep .' will only match non-empty lines. Also add a 'continue' to the empty-zone branch, which I'd missed in 5d9d973 (ci-operator/step-registry/gather/gcp-console: Gather console logs on GCP, 2020-11-04, openshift#13398). [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-e2e-gcp-upgrade-4.7/1340262366092201984#1:build-log.txt%3A171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the similar aws-console step, but for GCP, following these docs. I'm not sure why they require a
--zoneargument wheninstances listseems to be able to figure this out, but whatever. Leaving it off doesn't seem to be an option:OWNERSare like AWS, from 390d6be (#9743), and also the installer's GCP approvers. CC @cgwalters, @enxebre, @jstuever, @patrickdillon, @vrutkovs.