-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci-operator/step-registry/gather: Exclude empty-string "instance IDs" #14467
ci-operator/step-registry/gather: Exclude empty-string "instance IDs" #14467
Conversation
I'm not quite sure where the empty line came from, but [1] had: 2020/12/19 12:29:58 Executing pod "e2e-gcp-upgrade-gather-gcp-console" 2020/12/19 12:30:03 Container cp-secret-wrapper in pod e2e-gcp-upgrade-gather-gcp-console completed successfully Activated service account credentials for: [do-not-delete-ci-provisioner@openshift-gce-devel-ci.iam.gserviceaccount.com] Updated property [core/project]. Finding the zone for No zone found for , so not attempting to gather console logs Gathering console logs for from ERROR: (gcloud.compute.instances.get-serial-port-output) could not parse resource [] error: failed to execute wrapped command: exit status 1 2020/12/19 12:30:13 Container test in pod e2e-gcp-upgrade-gather-gcp-console failed, exit code 1, reason Error The 'grep .' will only match non-empty lines. Also add a 'continue' to the empty-zone branch, which I'd missed in 5d9d973 (ci-operator/step-registry/gather/gcp-console: Gather console logs on GCP, 2020-11-04, openshift#13398). [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-e2e-gcp-upgrade-4.7/1340262366092201984#1:build-log.txt%3A171
Looks fine. |
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Trevor says it's fine. Let's merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, vrutkovs, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@wking: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…nstance IDs" Like we did for GCP in 7e1a515 (ci-operator/step-registry/gather: Exclude empty-string "instance IDs", 2020-12-19, openshift#14467). In this case, the empty-string example was [1]: Gathering console logs for /bin/bash: line 41: /logs/artifacts/: Is a directory [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/19836/rehearse-19836-pull-ci-openshift-origin-release-4.9-e2e-aws-disruptive
I'm not quite sure where the empty line came from, but this job had:
The
grep .
will only match non-empty lines.Also add a
continue
to the empty-zone branch, which I'd missed in 5d9d973 (#13398)./assign @cgwalters