ci-operator/step-registry/gather/aws-console: Use LC_ALL instead of PYTHONIOENCODING #19836
Conversation
openshift-ci
bot
added
the
approved
|
from 4.9-e2e-aws-disruptive: I've added b2fecba6ac, following GCP's #14467, to exclude empty-string "instance IDs". |
|
/hold For some reason my earlier request doesn't seem to have set the label. |
openshift-ci
bot
added
the
do-not-merge/hold
For debugging, so we don't have to guess the AWS CLI version when trying to decide why it's breaking.
…nstance IDs" Like we did for GCP in 7e1a515 (ci-operator/step-registry/gather: Exclude empty-string "instance IDs", 2020-12-19, openshift#14467). In this case, the empty-string example was [1]: Gathering console logs for /bin/bash: line 41: /logs/artifacts/: Is a directory [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/19836/rehearse-19836-pull-ci-openshift-origin-release-4.9-e2e-aws-disruptive
…YTHONIOENCODING 24b834c (ci-operator/step-registry/gather/aws-console: UTF-8 for output, 2021-06-29, openshift#19827) is not doing well in the wild. For example, [1]: INFO[2021-06-29T20:14:28Z] Gathering console logs for i-008f73fde1ef3f0dc 'ascii' codec can't encode character '\u2026' in position 13999: ordinal not in range(128) {"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2021-06-29T20:14:27Z"} error: failed to execute wrapped command: exit status 1 Apparently the AWS CLI is not using Python's default stream encoding here. But from [2,3,4] there is the suggestion that LC_ALL=en_US.UTF-8 will help. [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.9-e2e-aws/1409949910362492928 [2]: https://awscli.amazonaws.com/v2/documentation/api/latest/topic/config-vars.html#locale [3]: https://github.com/aws/aws-cli/blob/2.2.5/awscli/compat.py#L121-L146 [4]: https://docs.python.org/3/library/locale.html#locale.getpreferredencoding
wking
force-pushed
the
gather-aws-console-json
branch
from
b2fecba
to
1b472c0
Compare
wking
changed the title
|
This: suggests encode-to-JSON is not going to work. I've pushed b2fecba6ac -> 1b472c0, pivoting from JSON to using |
|
This looks good: $ wget https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/19836/rehearse-19836-pull-ci-openshift-cluster-logging-operator-tech-preview-e2e-operator/1410097682520739840/artifacts/e2e-operator/gather-aws-console/artifacts/i-000bbb4e6d1919ca7
$ file i-000bbb4e6d1919ca7
i-000bbb4e6d1919ca7: UTF-8 Unicode text, with very long lines, with CRLF, CR, LF line terminators, with escape sequences/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrutkovs, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For some reason I don't understand, 24b834c (#19827) is not doing well in the wild (although I have been unable to reproduce locally). For example:
I'd rather not revert, because I want these console logs.
Instead, I'm moving to JSON. It will be harder to read, but might have the non-ASCII output escaped.Edit: now I'm tryingLC_ALL.Wait for rehearsals this time:
/hold