Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-operator/step-registry/gather/aws-console: Use LC_ALL instead of PYTHONIOENCODING #19836

Merged
merged 3 commits into from
Jun 30, 2021
Merged

ci-operator/step-registry/gather/aws-console: Use LC_ALL instead of PYTHONIOENCODING #19836

merged 3 commits into from
Jun 30, 2021

Commits on Jun 30, 2021

  1. ci-operator/step-registry/gather/aws-console: Add 'aws --version' 

    For debugging, so we don't have to guess the AWS CLI version when
trying to decide why it's breaking.
    @wking
    wking committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    22bc15b View commit details
    Browse the repository at this point in the history

  2. ci-operator/step-registry/gather/aws-console: Exclude empty-string "i… 

    …nstance IDs"

Like we did for GCP in 7e1a515 (ci-operator/step-registry/gather:
Exclude empty-string "instance IDs", 2020-12-19, openshift#14467).  In this
case, the empty-string example was [1]:

  Gathering console logs for
  /bin/bash: line 41: /logs/artifacts/: Is a directory

[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/19836/rehearse-19836-pull-ci-openshift-origin-release-4.9-e2e-aws-disruptive
    @wking
    wking committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    0a0e1ab View commit details
    Browse the repository at this point in the history

  3. ci-operator/step-registry/gather/aws-console: Use LC_ALL instead of P… 

    …YTHONIOENCODING

24b834c (ci-operator/step-registry/gather/aws-console: UTF-8 for
output, 2021-06-29, openshift#19827) is not doing well in the wild.  For
example, [1]:

  INFO[2021-06-29T20:14:28Z] Gathering console logs for i-008f73fde1ef3f0dc

  'ascii' codec can't encode character '\u2026' in position 13999: ordinal not in range(128)
  {"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2021-06-29T20:14:27Z"}
  error: failed to execute wrapped command: exit status 1

Apparently the AWS CLI is not using Python's default stream encoding
here.  But from [2,3,4] there is the suggestion that
LC_ALL=en_US.UTF-8 will help.

[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.9-e2e-aws/1409949910362492928
[2]: https://awscli.amazonaws.com/v2/documentation/api/latest/topic/config-vars.html#locale
[3]: https://github.com/aws/aws-cli/blob/2.2.5/awscli/compat.py#L121-L146
[4]: https://docs.python.org/3/library/locale.html#locale.getpreferredencoding
    @wking
    wking committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    1b472c0 View commit details
    Browse the repository at this point in the history