Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-operator/step-registry/gather: Exclude empty-string "instance IDs" #14467

Merged

Commits on Dec 19, 2020

  1. ci-operator/step-registry/gather: Exclude empty-string "instance IDs"

    I'm not quite sure where the empty line came from, but [1] had:
    
      2020/12/19 12:29:58 Executing pod "e2e-gcp-upgrade-gather-gcp-console"
      2020/12/19 12:30:03 Container cp-secret-wrapper in pod e2e-gcp-upgrade-gather-gcp-console completed successfully
      Activated service account credentials for: [do-not-delete-ci-provisioner@openshift-gce-devel-ci.iam.gserviceaccount.com]
      Updated property [core/project].
      Finding the zone for
      No zone found for , so not attempting to gather console logs
      Gathering console logs for  from
      ERROR: (gcloud.compute.instances.get-serial-port-output) could not parse resource []
      error: failed to execute wrapped command: exit status 1
      2020/12/19 12:30:13 Container test in pod e2e-gcp-upgrade-gather-gcp-console failed, exit code 1, reason Error
    
    The 'grep .' will only match non-empty lines.
    
    Also add a 'continue' to the empty-zone branch, which I'd missed in
    5d9d973 (ci-operator/step-registry/gather/gcp-console: Gather
    console logs on GCP, 2020-11-04, openshift#13398).
    
    [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-e2e-gcp-upgrade-4.7/1340262366092201984#1:build-log.txt%3A171
    wking committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    7e1a515 View commit details
    Browse the repository at this point in the history