installer smoke_tests use LOCAL_IMAGE for optional installer-smoke image #1517
Conversation
openshift-ci-robot
added
the
size/S
|
Cross-linking #1487. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sallyom, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@sallyom: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…smoke image" This reverts commit 50a2396, openshift#1517. It was giving us [1]: error: could not run steps: template e2e-aws-smoke has required parameter LOCAL_IMAGE_INSTALLER_SMOKE which is not defined and we're not clear on why. Reverting it helps unblock the installer merge queue while we figure it out. [1]: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/252/pull-ci-openshift-installer-e2e-aws-smoke/115/build-log.txt
…n't slow down e2e-aws" This reverts commit 02fac40, openshift#1487. Something funny was going on with optional [1], which resulted in 50a2396 (installer smoke_tests use LOCAL_IMAGE for optional installer-smoke image, 2018-09-14, openshift#1517). With 50a2396 reverted in the previous commit, we'll want to revert this one too until we figure out what was going on with both of them. [1]: openshift#1517 (comment)
|
This didn't actually work until openshift/ci-operator#149 |
|
I tested locally with a template, but you should double check with the latest ci-operator and the installer-smoke template. |
@smarterclayton this should fix the installer smoke tests.. docs were either not clear on the optional tag or i missed something there