Revert recent installer smoke-test changes #1518
Conversation
…smoke image" This reverts commit 50a2396, openshift#1517. It was giving us [1]: error: could not run steps: template e2e-aws-smoke has required parameter LOCAL_IMAGE_INSTALLER_SMOKE which is not defined and we're not clear on why. Reverting it helps unblock the installer merge queue while we figure it out. [1]: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/252/pull-ci-openshift-installer-e2e-aws-smoke/115/build-log.txt
openshift-ci-robot
added
the
size/S
…n't slow down e2e-aws" This reverts commit 02fac40, openshift#1487. Something funny was going on with optional [1], which resulted in 50a2396 (installer smoke_tests use LOCAL_IMAGE for optional installer-smoke image, 2018-09-14, openshift#1517). With 50a2396 reverted in the previous commit, we'll want to revert this one too until we figure out what was going on with both of them. [1]: openshift#1517 (comment)
wking
force-pushed
the
installer-local-smoke
branch
from
b901297
to
fcfdafa
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@wking: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
ci-operator was fixed in openshift/ci-operator#149 |
I'm reverting #1517, because it was giving us:
and we're not clear on why. Reverting it helps unblock the installer merge queue while we figure it out.
I'm also reverting #1487. #1517 was filed as a fixup for #1487 (although I'm a bit hazy on the details); so with #1517 reverted I thought we should probably back out #1487 for now too.