Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-operator/step-registry/gather/aws-console: UTF-8 for output #19827

Merged
merged 1 commit into from
Jun 29, 2021
Merged

ci-operator/step-registry/gather/aws-console: UTF-8 for output #19827

merged 1 commit into from
Jun 29, 2021

Commits on Jun 29, 2021

  1. ci-operator/step-registry/gather/aws-console: UTF-8 for output 

    In recent CI, we have failed console gathers like [1]:

  Gathering console logs for i-026ba0637214cd027
  'ascii' codec can't encode character '\u2026' in position 14093: ordinal not in range(128)
  Failed to gather console logs

This is descended from d060927 (gather/aws-console: Make log
gathering non-fatal, 2021-04-14, openshift#17735).  But we want to gather these
logs, not silently fail to gather the logs.  This commit restores our
old "fail the step when we fail to gather" behavior, and sets
PYTHONIOENCODING [2] to ask for UTF-8 instead of ASCII output.

[1]: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-[…]e2e-aws-serial/gather-aws-console/build-log.txt
[2]: https://docs.python.org/3/using/cmdline.html#envvar-PYTHONIOENCODING
    @wking
    wking committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    24b834c View commit details
    Browse the repository at this point in the history