Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e: WorkerSubnet -> Subnet #4013

Merged
merged 1 commit into from
Jun 11, 2019
Merged

ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e: WorkerSubnet -> Subnet #4013

merged 1 commit into from
Jun 11, 2019

Conversation

wking
Copy link
Member

@wking wking commented Jun 9, 2019

@wking
ci-operator/templates/openshift/installer/cluster-launch-installer-up…
456f258 
…i-e2e: WorkerSubnet -> Subnet

Catching up with openshift/installer@e45521e9 (Text edits for the
CloudFormation templates, 2019-05-28, openshift/installer#1794).
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 9, 2019
@openshift-ci-robot
Copy link
Contributor

@wking: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/e2e-vsphere 456f258 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-upi 456f258 link /test pj-rehearse
ci/prow/pj-rehearse 456f258 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a1a9729 into openshift:master Jun 11, 2019
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the following 2 configmaps:

  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci-stg using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml

In response to this:

Catching up with openshift/installer@e45521e9 (openshift/installer#1794).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the aws-upi-worker-subnet-rename branch June 12, 2019 04:15
wking added a commit to wking/openshift-release that referenced this pull request Dec 5, 2019
@wking
ci-operator/templates/openshift/installer/cluster-launch-installer-up…
545d327 
…i*: WorkerSubnet for 4.1

456f258
(ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e:
WorkerSubnet -> Subnet, 2019-06-09, openshift#4013) does not apply to 4.1.
Switch on BRANCH to use the old WorkerSubnet for 4.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronlevy aaronlevy Awaiting requested review from aaronlevy

@trown trown Awaiting requested review from trown

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wking @openshift-ci-robot @abhinavdahiya @openshift-merge-robot