Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow-scheduler: Add scheduler in prow-controller-manager #49859

Merged

Conversation

danilo-gemoli
Copy link
Contributor

@danilo-gemoli danilo-gemoli commented Mar 14, 2024

Add the scheduler in prow-controller-manager.
The flag --enable-controller=plank is also needed since plank is enabled by default only when no controller is passed as an argument.
This PR doesn't enable scheduling because it doesn't set:

scheduler:
  enabled: true

therefore ProwJobs are still being created in triggered state by each component in Prow.

I just want to make sure the scheduler controller runs and doesn't cause any trouble at least.
I will watch the rolling and, if everything goes smoothly, I am going to enable scheduling as well.

@openshift-ci openshift-ci bot requested review from jmguzik and Toma5OD March 14, 2024 08:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 14, 2024
@danilo-gemoli
Copy link
Contributor Author

time="2024-03-14T08:46:06Z" level=fatal msg="could not update Prow configuration" error="failed to load Prow config in strict mode: error unmarshaling /tmp/tmp.L3vC3R6cCc/_config.yaml: error unmarshaling JSON: while decoding JSON: json: unknown field \"scheduler\""

Ok we have some inter-repository dependencies. I can't use a new Prow configuration in o/release if Prow isn't up to date in o/ci-tools and I can't update Prow in o/ci-tools if it hasn't been updated in o/ci-chat-bot and o/release-controller too.

@danilo-gemoli danilo-gemoli force-pushed the feat/scheduler-in-prow-cm branch from 2c9cbf4 to 729d90a Compare March 14, 2024 16:32
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@danilo-gemoli: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@danilo-gemoli
Copy link
Contributor Author

/hold
it needs openshift/ci-tools#4047

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2024
@danilo-gemoli
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

@danilo-gemoli: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danilo-gemoli
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2024
@Prucek
Copy link
Member

Prucek commented Mar 15, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, Prucek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit aad82a2 into openshift:master Mar 15, 2024
22 checks passed
Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

@danilo-gemoli: Updated the config configmap in namespace ci at cluster app.ci using the following files:

  • key config.yaml using file core-services/prow/02_config/_config.yaml

In response to this:

Add the scheduler in prow-controller-manager.
The flag --enable-controller=plank is also needed since plank is enabled by default only when no controller is passed as an argument.
This PR doesn't enable scheduling because it doesn't set:

scheduler:
 enabled: true

therefore ProwJobs are still being created in triggered state by each component in Prow.

I just want to make sure the scheduler controller runs and doesn't cause any trouble at least.
I will watch the rolling and, if everything goes smoothly, I am going to enable scheduling as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rh-rahulshetty pushed a commit to rh-rahulshetty/release that referenced this pull request Mar 18, 2024
BradLugo pushed a commit to BradLugo/openshift-release that referenced this pull request Jun 13, 2024
@danilo-gemoli danilo-gemoli deleted the feat/scheduler-in-prow-cm branch June 29, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants