-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prow-scheduler: Add scheduler in prow-controller-manager #49859
prow-scheduler: Add scheduler in prow-controller-manager #49859
Conversation
Ok we have some inter-repository dependencies. I can't use a new Prow configuration in |
2c9cbf4
to
729d90a
Compare
[REHEARSALNOTIFIER] Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/hold |
/retest |
@danilo-gemoli: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/unhold |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danilo-gemoli, Prucek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@danilo-gemoli: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add the scheduler in
prow-controller-manager
.The flag
--enable-controller=plank
is also needed sinceplank
is enabled by default only when no controller is passed as an argument.This PR doesn't enable scheduling because it doesn't set:
therefore ProwJobs are still being created in
triggered
state by each component in Prow.I just want to make sure the scheduler controller runs and doesn't cause any trouble at least.
I will watch the rolling and, if everything goes smoothly, I am going to enable
scheduling
as well.