Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow-scheduler: Enable scheduling #49983

Conversation

danilo-gemoli
Copy link
Contributor

ProwJob CRD has been updated #49766 and the scheduler is actually running #49859.
This PR enables a PJ to be created in state: scheduling by the components cited in these PRs:

The current scheduling strategy is failover with no mappings (see here), so this means the scheduler will simply update .status.state of each PJ, leaving .spec.cluster untouched.

The following is an example of how the reconciler would patch a PJ:

apiVersion: prow.k8s.io/v1
kind: ProwJob
spec:
  cluster: build05
status:
- state: scheduling
+ state: triggered

/cc @openshift/test-platform

@openshift-ci openshift-ci bot requested a review from a team March 19, 2024 09:31
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 19, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@danilo-gemoli: no rehearsable tests are affected by this change

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2024
@danilo-gemoli
Copy link
Contributor Author

If it is going to work, this PR formally concludes: Scheduling in Prow
FYI @stevekuznetsov @petr-muller

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2024
Copy link
Contributor

openshift-ci bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, jmguzik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Mar 19, 2024

@danilo-gemoli: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1243c15 into openshift:master Mar 19, 2024
11 checks passed
Copy link
Contributor

openshift-ci bot commented Mar 19, 2024

@danilo-gemoli: Updated the config configmap in namespace ci at cluster app.ci using the following files:

  • key config.yaml using file core-services/prow/02_config/_config.yaml

In response to this:

ProwJob CRD has been updated #49766 and the scheduler is actually running #49859.
This PR enables a PJ to be created in state: scheduling by the components cited in these PRs:

The current scheduling strategy is failover with no mappings (see here), so this means the scheduler will simply update .status.state of each PJ, leaving .spec.cluster untouched.

The following is an example of how the reconciler would patch a PJ:

apiVersion: prow.k8s.io/v1
kind: ProwJob
spec:
 cluster: build05
status:
- state: scheduling
+ state: triggered

/cc @openshift/test-platform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rh-rahulshetty pushed a commit to rh-rahulshetty/release that referenced this pull request Mar 19, 2024
BradLugo pushed a commit to BradLugo/openshift-release that referenced this pull request Jun 13, 2024
@danilo-gemoli danilo-gemoli deleted the feat/scheduler/enable-scheduling branch June 29, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants