-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: OADP velero 1.4 branch #53237
fix: OADP velero 1.4 branch #53237
Conversation
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse |
@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse ack |
@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/pj-rehearse ack
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mateusoliveira43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR addresses issue with ci-tools openshift/ci-tools#4165 |
@mateusoliveira43: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
87a8c13
into
openshift:master
@@ -33,7 +33,7 @@ tests: | |||
steps: | |||
test: | |||
- as: unit | |||
commands: make -f Makefile.prow ci | |||
commands: PATH="/go/bin:$PATH" make -f Makefile.prow ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which image is that from?
I wonder if it's not easier to use one of the go env
to ensure it's there ,because we can't be sure konveyor will always stay there:
https://github.com/konveyor/builder/blob/main/Dockerfile.ubi9#L13-L32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From here https://github.com/openshift/ci-tools/blame/master/pkg/steps/source.go#L102
This is added to our image when our repo is configured to use imagestreamtag which openshift prow replaces FROM
in our dockerfile. Not something specified in konveyor builder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image_stream_tag line 2 (which would be fine)
but as Tiger noted openshift/ci-tools#4165 this is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks !
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Fix for unit tests in branch oadp-1.4 of Velero fork.