Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-4308: Don't consider unschedulable pods unrecoverable #317

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

sseago
Copy link

@sseago sseago commented Jun 14, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 14, 2024

@sseago: This pull request references OADP-4308 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mateusoliveira43
Copy link

For unit tests to pass, need these 2 PRs:

Copy link

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
Copy link
Member

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mpryc
Copy link

mpryc commented Jun 14, 2024

CI issue - goimports, but it's known

Copy link

openshift-ci bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kaovilai, mpryc, shubham-pampattiwar, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sseago
Copy link
Author

sseago commented Jun 14, 2024

Fix forthcoming for unit tests. Prow will still fail them, though.

Signed-off-by: Scott Seago <sseago@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
Copy link

openshift-ci bot commented Jun 14, 2024

@sseago: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-test 9decb91 link false /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sseago
Copy link
Author

sseago commented Jun 14, 2024

/override ci/prow/unit-test

Copy link

openshift-ci bot commented Jun 14, 2024

@sseago: sseago unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

/override ci/prow/unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shubham-pampattiwar
Copy link
Member

/override ci/prow/unit-test

Copy link

openshift-ci bot commented Jun 14, 2024

@shubham-pampattiwar: shubham-pampattiwar unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

/override ci/prow/unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@weshayutin
Copy link

ok  	github.com/vmware-tanzu/velero/internal/volume	0.051s	coverage: 48.9% of statements
ok  	github.com/vmware-tanzu/velero/internal/volumehelper	0.057s	coverage: 37.4% of statements
Success!
make[1]: Leaving directory '/home/whayutin/OPENSHIFT/git/OADP/velero'

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
@weshayutin weshayutin merged commit 6fbcfbf into openshift:oadp-1.4 Jun 14, 2024
1 of 3 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants