Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hcp|kv|disconnected] Various fixes for hcp|kv|disconnected periodics #54062

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tiraboschi
Copy link
Contributor

@tiraboschi tiraboschi commented Jul 5, 2024

Various fixes for hcp|kv|disconnected periodics:

  • fix the right version of ODF for v4.14 and v41.5
  • explicitly configure a ImageDigestMirrorSet for CSI sidecar images for ODF
  • use MCE 2.6 on v4.16 job
  • add a post step to eventually highlight missing images
  • start reporting again v4.16 and v4.17 to slack
  • execute with equinix-ocp-hcp cluster profile

@openshift-ci openshift-ci bot requested review from csrwng and davidvossel July 5, 2024 14:02
@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-metal-mce-disconnected
/pj-rehearse periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-kubevirt-metal-ovn-mce-disconnected
/pj-rehearse periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-kubevirt-metal-ovn-mce-disconnected
/pj-rehearse periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-kubevirt-metal-ovn-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

2 similar comments
@openshift-ci-robot
Copy link
Contributor

@tiraboschi: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-kubevirt-metal-ovn-mce-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-kubevirt-metal-ovn-mce-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-kubevirt-metal-ovn-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-metal-mce-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-kubevirt-metal-ovn-mce-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-kubevirt-metal-ovn-mce-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-kubevirt-metal-ovn-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-kubevirt-metal-ovn-mce-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-kubevirt-metal-ovn-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-kubevirt-metal-ovn-mce-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-metal-mce-disconnected

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-kubevirt-metal-ovn-mce-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-metal-mce-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-kubevirt-metal-ovn-mce-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-kubevirt-metal-ovn-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-kubevirt-metal-ovn-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-metal-mce-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-metal-mce-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-kubevirt-metal-ovn-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

- fix the right version of ODF for v4.14 and v41.5
- explicitly configure a ImageDigestMirrorSet for CSI sidecar images for ODF
- use MCE 2.6 on v4.16 job
- add a post step to eventually highlight missing images
- start reporting again v4.16 and v4.17 to slack

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@tiraboschi: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-api-provider-kubevirt-main-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.18-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.17-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.16-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.15-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.14-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.18-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.17-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.16-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.15-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.14-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.13-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.12-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.11-e2e-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-kubevirt openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.18-e2e-aws-ovn-kubevirt openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.17-e2e-aws-ovn-kubevirt openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.16-e2e-aws-ovn-kubevirt openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.15-e2e-aws-ovn-kubevirt openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.14-e2e-aws-ovn-kubevirt openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-cloud-provider-kubevirt-main-hypershift-kubevirt-conformance-baremetalds openshift/cloud-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cloud-provider-kubevirt-release-4.18-hypershift-kubevirt-conformance-baremetalds openshift/cloud-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cloud-provider-kubevirt-release-4.17-hypershift-kubevirt-conformance-baremetalds openshift/cloud-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cloud-provider-kubevirt-release-4.16-hypershift-kubevirt-conformance-baremetalds openshift/cloud-provider-kubevirt presubmit Registry content changed

A total of 220 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@tiraboschi
Copy link
Contributor Author

only 2/3 individual tests failed here and there, v4.14, v4.15 and v4.16 (with MCE) and v4.17 (without MCE) lanes worked e2e.
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 15, 2024
Copy link
Contributor

openshift-ci bot commented Jul 15, 2024

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-kubevirt-metal-ovn-disconnected 1b351a2 link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-kubevirt-metal-ovn-disconnected
ci/rehearse/periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-metal-mce-disconnected 1b351a2 link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-metal-mce-disconnected
ci/rehearse/periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-kubevirt-metal-ovn-mce-disconnected 1b351a2 link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-kubevirt-metal-ovn-mce-disconnected

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@@ -23,6 +23,7 @@ workflow:
allow_best_effort_post_steps: true
allow_skip_on_success: true
post:
- ref: hypershift-kubevirt-baremetalds-disconnected-highlightmissingimages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also adding it to hypershift-kubevirt-baremetalds-disconnected-conformance-workflow.yaml which is not calling hypershift-mce-dump, but more than that is a matter of visibility: for sure we already have all the info we need to debug an issue in the must-gather archives we are already collecting, but getting at least one of the images not correctly mirrored on the internal registry is by far the most common issue in those disconnected lanes and this new step will highlight it if the issue is really there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, Thanks

@LiangquanLi930
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
Copy link
Contributor

openshift-ci bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LiangquanLi930, tiraboschi
Once this PR has been reviewed and has the lgtm label, please assign davidvossel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants