-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hcp|kv|disconnected] Various fixes for hcp|kv|disconnected periodics #54062
Merged
openshift-merge-bot
merged 2 commits into
openshift:master
from
tiraboschi:fix_hcp_kv_disconnected
Jul 16, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
.../step-registry/hypershift/kubevirt/baremetalds/disconnected/highlightmissingimages/OWNERS
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
approvers: | ||
- csrwng | ||
- enxebre | ||
- sjenning | ||
- imain | ||
- LiangquanLi930 | ||
- davidvossel | ||
- orenc1 | ||
- tiraboschi | ||
options: {} | ||
reviewers: | ||
- csrwng | ||
- enxebre | ||
- sjenning | ||
- imain | ||
- LiangquanLi930 | ||
- davidvossel | ||
- orenc1 | ||
- tiraboschi |
13 changes: 13 additions & 0 deletions
13
...ingimages/hypershift-kubevirt-baremetalds-disconnected-highlightmissingimages-commands.sh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
#!/bin/bash | ||
|
||
set -x | ||
|
||
echo "--- Management cluster ---" | ||
oc get pods -A -o yaml | grep "Back-off pulling image" | sort | uniq | ||
|
||
echo "--- Hosted cluster ---" | ||
if [[ -f "${SHARED_DIR}/nested_kubeconfig" ]]; then | ||
export KUBECONFIG="${SHARED_DIR}/nested_kubeconfig" | ||
oc get pods -A -o yaml | grep "Back-off pulling image" | sort | uniq | ||
fi | ||
|
25 changes: 25 additions & 0 deletions
25
...ges/hypershift-kubevirt-baremetalds-disconnected-highlightmissingimages-ref.metadata.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
{ | ||
"path": "hypershift/kubevirt/baremetalds/disconnected/highlightmissingimages/hypershift-kubevirt-baremetalds-disconnected-highlightmissingimages-ref.yaml", | ||
"owners": { | ||
"approvers": [ | ||
"csrwng", | ||
"enxebre", | ||
"sjenning", | ||
"imain", | ||
"LiangquanLi930", | ||
"davidvossel", | ||
"orenc1", | ||
"tiraboschi" | ||
], | ||
"reviewers": [ | ||
"csrwng", | ||
"enxebre", | ||
"sjenning", | ||
"imain", | ||
"LiangquanLi930", | ||
"davidvossel", | ||
"orenc1", | ||
"tiraboschi" | ||
] | ||
} | ||
} |
12 changes: 12 additions & 0 deletions
12
...issingimages/hypershift-kubevirt-baremetalds-disconnected-highlightmissingimages-ref.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
ref: | ||
as: hypershift-kubevirt-baremetalds-disconnected-highlightmissingimages | ||
from: cli | ||
grace_period: 10m | ||
commands: hypershift-kubevirt-baremetalds-disconnected-highlightmissingimages-commands.sh | ||
resources: | ||
requests: | ||
cpu: 1000m | ||
memory: 500Mi | ||
timeout: 10m0s | ||
documentation: |- | ||
This step to quickly identify missing images on disconnected test lanes |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, hypershift-mce-dump can accomplish the same thing.
E.g: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/54062/rehearse-54062-periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-metal-mce-disconnected/1812774648182476800/artifacts/e2e-kubevirt-metal-mce-disconnected/hypershift-mce-dump/artifacts/hostedcluster-6d047c994a7bcc9e751e/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also adding it to
hypershift-kubevirt-baremetalds-disconnected-conformance-workflow.yaml
which is not callinghypershift-mce-dump
, but more than that is a matter of visibility: for sure we already have all the info we need to debug an issue in the must-gather archives we are already collecting, but getting at least one of the images not correctly mirrored on the internal registry is by far the most common issue in those disconnected lanes and this new step willhighlight
it if the issue is really there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, Thanks