Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sriov-network-operator] Rename dockerfile #54079

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Jul 5, 2024

For openshift/sriov-network-operator#955

Not sure if additional files need to change here since more than one dockerfile names were changed, please verify

@zeeke
Copy link
Contributor

zeeke commented Jul 10, 2024

Not sure if additional files need to change here since more than one dockerfile names were changed, please verify

The same file contains references to all those Dockerfiles:

https://github.com/openshift/release/pull/54079/files#diff-c4aa5f93d57db68bbc08cb80f9a0504388a434755a8394b7a0ed4ab7ddcf1d7eR55
https://github.com/openshift/release/pull/54079/files#diff-c4aa5f93d57db68bbc08cb80f9a0504388a434755a8394b7a0ed4ab7ddcf1d7eR37

Can you update them?

@ashwindasr ashwindasr force-pushed the sriov-network-operator-rename-dockerfile branch from 8dbc757 to dfacb61 Compare July 10, 2024 18:09
@ashwindasr
Copy link
Contributor Author

Thanks @zeeke, I've updated and repushed. ptal when you get the chance

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@ashwindasr: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-sriov-network-operator-master-api openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-ci-index-sriov-network-operator-bundle openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-controllers openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-e2e-openstack-nfv openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-e2e-openstack-nfv-hwoffload openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-e2e-telco5g-cnftests openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-gofmt openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-images openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-operator-e2e openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-pkg openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-security openshift/sriov-network-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@ashwindasr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zeeke
Copy link
Contributor

zeeke commented Jul 11, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2024
Copy link
Contributor

openshift-ci bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ashwindasr, zeeke
Once this PR has been reviewed and has the lgtm label, please assign dougbtv for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
3 participants