Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Rename Dockerfile #955

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Jul 5, 2024

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#54079 (probably needs to merge first)

Please follow up with other changes in this/other repos if necessary. Please reach out to ART once this PR is ready to merge.

Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ashwindasr
Once this PR has been reviewed and has the lgtm label, please assign zshi-redhat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

@ashwindasr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/operator-e2e a7cd7f7 link true /test operator-e2e
ci/prow/images a7cd7f7 link true /test images
ci/prow/ci-index-sriov-network-operator-bundle a7cd7f7 link true /test ci-index-sriov-network-operator-bundle
ci/prow/e2e-openstack-nfv a7cd7f7 link false /test e2e-openstack-nfv
ci/prow/e2e-openstack-nfv-hwoffload a7cd7f7 link false /test e2e-openstack-nfv-hwoffload

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ashwindasr ashwindasr changed the title Rename Dockerfile NO-JIRA: Rename Dockerfile Jul 9, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2024
@openshift-ci-robot
Copy link
Contributor

@ashwindasr: This pull request explicitly references no jira issue.

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: openshift/release#54079 (probably needs to merge first)

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ashwindasr
Copy link
Contributor Author

/hold

Needs to merge with an ocp-build-data PR

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2024
@SchSeba
Copy link
Contributor

SchSeba commented Jul 17, 2024

Hi @ashwindasr I am fine with the changes do you prefer to merge the release repo first?

@ashwindasr
Copy link
Contributor Author

ashwindasr commented Jul 17, 2024

Thanks @SchSeba, yes lets get the release PR in first. Also if you can lgtm, approve to this PR as well, I can shepherd the PRs to merge

@ashwindasr
Copy link
Contributor Author

also the release PR openshift/release#54079 seems to be missing a approved label?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants