Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hive: Fix periodic image jobs #54083

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Hive: Fix periodic image jobs #54083

merged 1 commit into from
Jul 5, 2024

Conversation

2uasimojo
Copy link
Member

Sync with master presubmits

@2uasimojo
Hive: Fix periodic image jobs
1c6b6cc 
Sync with master presubmits
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2024
@openshift-ci openshift-ci bot requested review from jstuever and suhanime July 5, 2024 20:58
@2uasimojo 2uasimojo mentioned this pull request Jul 5, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@2uasimojo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hive-master-periodic-images openshift/hive presubmit Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-e2e-pool-weekly N/A periodic Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-e2e-weekly N/A periodic Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-e2e-azure-weekly N/A periodic Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-e2e-gcp-weekly N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@2uasimojo
Copy link
Member Author

/pj-rehearse pull-ci-openshift-hive-master-periodic-images periodic-ci-openshift-hive-master-periodic-e2e-weekly periodic-ci-openshift-hive-master-periodic-e2e-gcp-weekly

@openshift-ci-robot
Copy link
Contributor

@2uasimojo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@2uasimojo 2uasimojo mentioned this pull request Jul 5, 2024
Merged
@celebdor
Copy link
Contributor

celebdor commented Jul 5, 2024

/lgtm

@2uasimojo
Copy link
Member Author

/pj-rehearse ack

If the e2es were going to fail based on image changes, they would have done so already. Let's go!

@openshift-ci-robot
Copy link
Contributor

@2uasimojo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 5, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, celebdor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d96b641 into openshift:master Jul 5, 2024
17 of 18 checks passed
@2uasimojo 2uasimojo deleted the hive-fix-periodics branch July 8, 2024 15:01
@2uasimojo
Copy link
Member Author

Last night's periodic passed ✓

ptalgulk01 pushed a commit to ptalgulk01/release that referenced this pull request Jul 10, 2024
@2uasimojo @Prachiti2002
Hive: Fix periodic image jobs (openshift#54083)
a734fef 
Sync with master presubmits
jtaleric pushed a commit to jtaleric/release that referenced this pull request Jul 15, 2024
@2uasimojo
Hive: Fix periodic image jobs (openshift#54083)
5f3717d 
Sync with master presubmits
Neha-dot-Yadav pushed a commit to Neha-dot-Yadav/release that referenced this pull request Jul 19, 2024
@2uasimojo @Neha-dot-Yadav
Hive: Fix periodic image jobs (openshift#54083)
3595fe0 
Sync with master presubmits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@suhanime suhanime Awaiting requested review from suhanime

Assignees

@celebdor celebdor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2uasimojo @openshift-ci-robot @celebdor