Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-12007: d/s: CSV adjustment for sriov-network-metrics-exporter #951

Closed
wants to merge 1 commit into from

Conversation

zeeke
Copy link
Contributor

@zeeke zeeke commented Jul 3, 2024

Update ClusterServiceVersion with the new permissions and environment variables.

Add operatorframework.io/cluster-monitoring: true annotation to make the operator namespace be watched by the monitoring stack, when installing via web console.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2024
@openshift-ci openshift-ci bot requested review from Billy99 and SchSeba July 3, 2024 10:36
@zeeke
Copy link
Contributor Author

zeeke commented Jul 3, 2024

depends on

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2024
@zeeke zeeke force-pushed the metrics-exporter-ds branch 2 times, most recently from e82b362 to dad6889 Compare July 3, 2024 16:20
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2024
@zeeke zeeke changed the title d/s: CSV adjustment for sriov-network-metrics-exporter CNF-11147: d/s: CSV adjustment for sriov-network-metrics-exporter Jul 5, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 5, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 5, 2024

@zeeke: This pull request references CNF-11147 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Update ClusterServiceVersion with the new permissions and environment variables.

Add operatorframework.io/cluster-monitoring: true annotation to make the operator namespace be watched by the monitoring stack, when installing via web console.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2024
@zeeke
Copy link
Contributor Author

zeeke commented Jul 5, 2024

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2024
@zeeke zeeke changed the title CNF-11147: d/s: CSV adjustment for sriov-network-metrics-exporter CNF-12007: d/s: CSV adjustment for sriov-network-metrics-exporter Jul 15, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 15, 2024

@zeeke: This pull request references CNF-12007 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Update ClusterServiceVersion with the new permissions and environment variables.

Add operatorframework.io/cluster-monitoring: true annotation to make the operator namespace be watched by the monitoring stack, when installing via web console.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zeeke zeeke force-pushed the metrics-exporter-ds branch 2 times, most recently from 1407527 to e37c39f Compare July 18, 2024 10:28
Copy link
Contributor

openshift-ci bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2024
Update ClusterServiceVersion with the new permissions and environment variables.

Add `operatorframework.io/cluster-monitoring: true` annotation to make the operator
namespace be watched by the monitoring stack, when installing via web console.

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2024
Copy link
Contributor

openshift-ci bot commented Jul 30, 2024

@zeeke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv ab17387 link false /test e2e-openstack-nfv

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zeeke
Copy link
Contributor Author

zeeke commented Jul 31, 2024

/hold cancel

@SchSeba please take a look. u/s PR has been merged

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2024
@zeeke
Copy link
Contributor Author

zeeke commented Aug 5, 2024

superseded by

@zeeke zeeke closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants