CNF-12007: d/s Merge 20240801 #977
Conversation
We have to verify only the VF range we have specified. If not we will expect VFs to have certain values that have not been synced by the controller.
…depolicy-test e2e: fix e2e test for the sriovnetworknodepolicy
Switched to Go modules for dependency management. This simplifies our workflow and reduces repo size. Signed-off-by: Tobias Giese <tgiese@nvidia.com> Co-authored-by: Soule BA <souleb@nvidia.com> Co-authored-by: killianmuldoon <kmuldoon@nvidia.com>
We have issue with GOPATH if no HOME env is set. To fix this we want to make the current directory as our new home. Signed-off-by: Tobias Giese <tgiese@nvidia.com> Co-authored-by: Andrea Panattoni <apanatto@redhat.com>
Signed-off-by: Tobias Giese <tgiese@nvidia.com>
The feature gate controls state of the manage software bridge feature. This feature is disabled by default. Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
Signed-off-by: Tobias Giese <tgiese@nvidia.com> Co-authored-by: Andrea Panattoni <apanatto@redhat.com>
…roller-part [software-bridges 4/x] Controller part
With the GH dark theme 40% of the image is not readable. Setting the images background to white fixes this issue. Signed-off-by: Tobias Giese <tgiese@nvidia.com>
Signed-off-by: amaslennikov <amaslennikov@nvidia.com>
switch sriov module to use the new interface Signed-off-by: amaslennikov <amaslennikov@nvidia.com>
new package incapsulates the guid config file validation, guid pool implementation and host manipulations to set IB VF GUIDs
Signed-off-by: amaslennikov <amaslennikov@nvidia.com>
Signed-off-by: amaslennikov <amaslennikov@nvidia.com>
docs: add background to workflow png
Configure IB VFs' GUIDs using a statically provided GUID pool
chore: remove vendor directory
Package `github.com/prometheus-operator/prometheus-operator/pkg/client` can be used for testing purpose. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
Deploy the needed configuration to make the prometheus operator to find and scrape the sriov-network-metrics-exporter endpoints, including the ServiceMonitor, Role and RoleBinding. Resources are installed only if the Prometheus operator is installed. When useing `ServiceMonitors`, Prometheus Operator needs permissions to read Services,Endpoint and Pods in the monitored namespace (i.e. the SRIOV operator ns). Make the ServiceAccount subject configurable via environment variables. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
[metrics 2/x] Configure Prometheus Operator
Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
openshift-ci
bot
added
the
approved
|
@zeeke: This pull request references CNF-12007 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
please run the make bundle and also add the new env variables for the metrics in the csv |
OpenShift CI forces `GOFLAGS="-mod=vendor"`, which causes ``` GOFLAGS=-mod=vendor make controller-gen Downloading sigs.k8s.io/controller-tools/cmd/controller-gen@v0.14.0 go: sigs.k8s.io/controller-tools/cmd/controller-gen@v0.14.0: cannot query module due to -mod=vendor make: *** [Makefile:158: controller-gen] Error 1 ``` Clear the environment variable for the scope of the tool installation (`go install ... `command). Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
Update ClusterServiceVersion with the new permissions and environment variables. Add `operatorframework.io/cluster-monitoring: true` annotation to make the operator namespace be watched by the monitoring stack, when installing via web console. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
|
/retest |
|
/test ? |
|
@zeeke: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@zeeke: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SchSeba, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 17523b7
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-config-daemon |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-webhook |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-operator |
This sync merge includes the upstream vendor folder removal, re-added in 1c79708
supersedes:
cc @SchSeba