Skip to content

Commit

Permalink
Now stops all logging during add-on termination (fixes unreported bug…
Browse files Browse the repository at this point in the history
… with plugin reloads).
  • Loading branch information
Luke Davis authored and XLTechie committed Aug 31, 2023
1 parent 7648ad4 commit 37c456d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
3 changes: 3 additions & 0 deletions addon/globalPlugins/speechLogger/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@ def speechLogger_speakWithoutPauses( # noqa: C901
SpeechWithoutPauses.speakWithoutPauses = speechLogger_speakWithoutPauses

def terminate(self) -> None:
# Stop all logging that may be in progress
self.stopRemoteLog()
self.stopLocalLog()
# Remove the NVDA settings panel
if not globalVars.appArgs.secure:
gui.settingsDialogs.NVDASettingsDialog.categoryClasses.remove(SpeechLoggerSettings)
Expand Down
2 changes: 1 addition & 1 deletion buildVars.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def _(arg):
# Translators: Long description to be shown for this add-on on add-on information from add-ons manager
"addon_description": _("""Logs speech utterances to a file. Can also log NVDA remote session speech from the NVDA Remote add-on, to the same or another file."""),
# version
"addon_version": "23.3.004",
"addon_version": "23.3.01",
# Author(s)
"addon_author": "Luke Davis <XLTechie@newanswertech.com>, James Scholes",
# URL for the add-on documentation support
Expand Down
5 changes: 5 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
### 23.3.01

* New feature: can be configured to automatically start logging at NVDA startup. (#9)
* Now stop all logging during add-on termination (fixes unreported bug with plugin reloads).

### 23..2.08

* Fixed the position of a checkbox in configuration display (contributed in #8 by @CyrilleB79).
Expand Down

0 comments on commit 37c456d

Please sign in to comment.