Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use update_containers role to update openstack services container image #1884

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

raukadah
Copy link
Contributor

@raukadah raukadah commented Jun 17, 2024

This pr keeps the set_openstack_containers role when cifmw_update_containers_openstack var is not defined and use update_containers only when cifmw_update_containers_openstack is defined.

Apart from this, this pr also updates:

  • Reproducer content provider to use update_containers role var
  • Removes duplicates OsContainer Image var from update_containers role
  • Move cifmw_update_containers var in edpm_prepare update_containers
    role call

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

raukadah added a commit to raukadah/tcib that referenced this pull request Jun 17, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/73f962371f61487c932306f936a09cb2

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 06m 24s
podified-multinode-edpm-deployment-crc FAILURE in 39m 41s
cifmw-crc-podified-edpm-baremetal FAILURE in 40m 46s
cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 47m 19s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 52s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 14s
✔️ cifmw-molecule-edpm_prepare SUCCESS in 4m 50s

raukadah added a commit to raukadah/tcib that referenced this pull request Jun 17, 2024
raukadah added a commit to raukadah/tcib that referenced this pull request Jun 17, 2024
raukadah added a commit to raukadah/tcib that referenced this pull request Jun 17, 2024
raukadah added a commit to raukadah/tcib that referenced this pull request Jun 17, 2024
raukadah added a commit to raukadah/tcib that referenced this pull request Jun 17, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/eefa4cc478be4e86a5acd993c0840dff

openstack-k8s-operators-content-provider FAILURE in 11m 51s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 59s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 40s
✔️ cifmw-molecule-edpm_prepare SUCCESS in 4m 47s

raukadah added a commit to raukadah/tcib that referenced this pull request Jun 18, 2024
raukadah added a commit that referenced this pull request Jun 18, 2024
Depends-On: #1884

Signed-off-by: Chandan Kumar <raukadah@gmail.com>
raukadah added a commit to raukadah/tcib that referenced this pull request Jun 18, 2024
raukadah added a commit to raukadah/tcib that referenced this pull request Jun 18, 2024
raukadah added a commit to raukadah/tcib that referenced this pull request Jun 18, 2024
raukadah added a commit that referenced this pull request Jun 18, 2024
Depends-On: #1884

Signed-off-by: Chandan Kumar <raukadah@gmail.com>
raukadah added a commit to raukadah/tcib that referenced this pull request Jun 18, 2024
This pr keeps the set_openstack_containers role when cifmw_update_containers_openstack
var is not defined and use update_containers only when cifmw_update_containers_openstack
is defined.

Apart from this, this pr also updates:
- Reproducer content provider to use update_containers role var
- Removes duplicates OsContainer Image var from update_containers role
- Move cifmw_update_containers var in edpm_prepare update_containers
  role call

Signed-off-by: Chandan Kumar <raukadah@gmail.com>
raukadah added a commit to raukadah/tcib that referenced this pull request Jun 19, 2024
raukadah added a commit that referenced this pull request Jun 19, 2024
Depends-On: #1884

Signed-off-by: Chandan Kumar <raukadah@gmail.com>
raukadah added a commit to raukadah/tcib that referenced this pull request Jun 19, 2024
@raukadah raukadah marked this pull request as ready for review June 19, 2024 09:49
@pablintino
Copy link
Collaborator

/approve

Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Jun 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fcc4bea into main Jun 19, 2024
7 of 8 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the update_containers branch June 19, 2024 12:50
openshift-merge-bot bot pushed a commit that referenced this pull request Jun 19, 2024
Depends-On: #1884

Signed-off-by: Chandan Kumar <raukadah@gmail.com>
raukadah added a commit to raukadah/tcib that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants