[tcib]Use inner ansible vars to expose dlrn md5 hash #1885

raukadah · 2024-06-17T03:42:21Z

Currently we use to slurp the content of dlrn.md5 file via run playbook running from zuul executor. Most of the time, It does not exposes the correct dlrn md5 file hash. In order to fix that,

We are moving log collection from zuul post run to tcib playbook to create the ansible var file and use the same to read the dlrn md5 hash file.

As a pull request owner and reviewers, I checked that:

Appropriate testing is done and actually running

openshift-ci · 2024-06-17T03:42:25Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Depends-On: openstack-k8s-operators/ci-framework#1885 Depends-On: openstack-k8s-operators/ci-framework#1884 Signed-off-by: Chandan Kumar <raukadah@gmail.com>

softwarefactory-project-zuul · 2024-06-17T05:23:06Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a9db92e3d37848c3bd80b1d7ec2493f5

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 56s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 38s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 12m 06s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 54s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 42s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 31s
❌ cifmw-tcib FAILURE in 36m 26s

Depends-On: openstack-k8s-operators/ci-framework#1885 Depends-On: openstack-k8s-operators/ci-framework#1884 Signed-off-by: Chandan Kumar <raukadah@gmail.com>

softwarefactory-project-zuul · 2024-06-17T08:07:42Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/43083d3f817a42508483e72331954518

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 58s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 21s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 13m 38s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 46s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 34s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 07s
❌ cifmw-tcib FAILURE in 35m 42s

Depends-On: openstack-k8s-operators/ci-framework#1885 Depends-On: openstack-k8s-operators/ci-framework#1884 Signed-off-by: Chandan Kumar <raukadah@gmail.com>

softwarefactory-project-zuul · 2024-06-17T15:13:30Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d3b42cf59d634afaba79bae7c15f9e91

❌ openstack-k8s-operators-content-provider FAILURE in 11m 33s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 11s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 35s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 58s
❌ cifmw-tcib FAILURE in 12m 07s

Depends-On: openstack-k8s-operators/ci-framework#1885 Depends-On: openstack-k8s-operators/ci-framework#1884 Signed-off-by: Chandan Kumar <raukadah@gmail.com>

raukadah · 2024-06-19T06:08:20Z

In the existing jobs running against tcib, from this buildset https://review.rdoproject.org/zuul/buildset/c9dc8ac1fbae4184802748ea2f60d4b3,
Taking https://review.rdoproject.org/zuul/build/3c51780008014895bbc16892baba0541 - tcib-crc-podified-edpm-baremetal job zuul inventory
https://logserver.rdoproject.org/77/177/baf3d9a9715a7fac1930c0682ade396dfed71ce3/github-check/tcib-crc-podified-edpm-baremetal/3c51780/zuul-info/inventory.yaml returns

content_provider_dlrn_md5_hash: ''
content_provider_registry_ip: 38.129.56.29

Since we are not able to read the dlrn md5 value on the zuul controller, In order to fix that. Let's use the ansible-var file generated by artifacts role.
#1885
We tested the above pr here: openstack-k8s-operators/tcib#178 and buildset :
https://review.rdoproject.org/zuul/buildset/99c124a493804ba99a14a3b1ba316706
tcib-crc-podified-edpm-baremetal - https://review.rdoproject.org/zuul/build/f92fd33efc99464e8ebec46d2faaf201 zuul inventory
https://logserver.rdoproject.org/78/178/55382c9287c6d47eff9ee047fcea75f8b234b687/github-check/tcib-crc-podified-edpm-baremetal/f92fd33/zuul-info/inventory.yaml

content_provider_dlrn_md5_hash: e72f31c85d92e63dff1ddc22b6d29110
content_provider_registry_ip: 38.129.56.173

Depends-On: openstack-k8s-operators/ci-framework#1885 Depends-On: openstack-k8s-operators/ci-framework#1884 Signed-off-by: Chandan Kumar <raukadah@gmail.com>

marios

lgtm, seems less fragile than the previous version

pablintino · 2024-06-19T08:54:28Z

ci/playbooks/tcib/run.yml

-          when: _check_dlrn_md5.stat.exists
+    - name: Get inner ansible vars
+      ansible.builtin.set_fact:
+        inner_ansible_vars: "{{ inner_ansible.content | b64decode | from_yaml }}"


Can we use a block to avoid decoding the same var 3 times and to avoid the fact?

Currently we use to slurp the content of dlrn.md5 file via run playbook running from zuul executor. Most of the time, It does not exposes the correct dlrn md5 file hash. In order to fix that, We are moving log collection from zuul post run to tcib playbook to create the ansible var file and use the same to read the dlrn md5 hash file. Signed-off-by: Chandan Kumar <raukadah@gmail.com>

Depends-On: openstack-k8s-operators/ci-framework#1885 Depends-On: openstack-k8s-operators/ci-framework#1884 Signed-off-by: Chandan Kumar <raukadah@gmail.com>

rebtoor · 2024-06-19T09:19:49Z

/approve

openshift-ci · 2024-06-19T09:19:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rebtoor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

frenzyfriday · 2024-06-19T10:49:05Z

/lgtm

Depends-On: openstack-k8s-operators/ci-framework#1885 Depends-On: openstack-k8s-operators/ci-framework#1884 Signed-off-by: Chandan Kumar <raukadah@gmail.com>

openshift-ci bot added the do-not-merge/work-in-progress label Jun 17, 2024

raukadah mentioned this pull request Jun 17, 2024

Move tcib jobs to update_containers role openstack-k8s-operators/tcib#178

Merged

raukadah force-pushed the tcib_logging branch from 03e8f91 to 07c4528 Compare June 17, 2024 05:24

raukadah force-pushed the tcib_logging branch from 07c4528 to 7ae2c56 Compare June 17, 2024 06:35

raukadah force-pushed the tcib_logging branch from 7ae2c56 to e39218c Compare June 17, 2024 08:07

raukadah marked this pull request as ready for review June 17, 2024 14:11

openshift-ci bot removed the do-not-merge/work-in-progress label Jun 17, 2024

github-actions bot added Ready For Review and removed Ready For Review labels Jun 17, 2024

raukadah force-pushed the tcib_logging branch from e39218c to ee2866b Compare June 17, 2024 14:14

raukadah force-pushed the tcib_logging branch from ee2866b to 5660af9 Compare June 18, 2024 04:58

github-actions bot added the Ready For Review label Jun 18, 2024

marios approved these changes Jun 19, 2024

View reviewed changes

openshift-ci bot assigned marios Jun 19, 2024

openshift-ci bot added the lgtm label Jun 19, 2024

pablintino reviewed Jun 19, 2024

View reviewed changes

raukadah force-pushed the tcib_logging branch from 5660af9 to fab80e7 Compare June 19, 2024 09:12

openshift-ci bot removed the lgtm label Jun 19, 2024

github-actions bot removed the Ready For Review label Jun 19, 2024

rebtoor approved these changes Jun 19, 2024

View reviewed changes

openshift-ci bot assigned rebtoor Jun 19, 2024

openshift-ci bot added the lgtm label Jun 19, 2024

openshift-ci bot added the approved label Jun 19, 2024

openshift-ci bot assigned frenzyfriday Jun 19, 2024

github-actions bot added Ready For Review and removed Ready For Review labels Jun 19, 2024

openshift-merge-bot bot merged commit 37cd7d9 into main Jun 19, 2024
5 checks passed

openshift-merge-bot bot deleted the tcib_logging branch June 19, 2024 12:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tcib]Use inner ansible vars to expose dlrn md5 hash #1885

[tcib]Use inner ansible vars to expose dlrn md5 hash #1885

raukadah commented Jun 17, 2024 •

edited

Loading

openshift-ci bot commented Jun 17, 2024

softwarefactory-project-zuul bot commented Jun 17, 2024

softwarefactory-project-zuul bot commented Jun 17, 2024

softwarefactory-project-zuul bot commented Jun 17, 2024

raukadah commented Jun 19, 2024

marios left a comment

pablintino Jun 19, 2024

raukadah Jun 19, 2024

rebtoor commented Jun 19, 2024

openshift-ci bot commented Jun 19, 2024

frenzyfriday commented Jun 19, 2024

[tcib]Use inner ansible vars to expose dlrn md5 hash #1885

[tcib]Use inner ansible vars to expose dlrn md5 hash #1885

Conversation

raukadah commented Jun 17, 2024 • edited Loading

openshift-ci bot commented Jun 17, 2024

softwarefactory-project-zuul bot commented Jun 17, 2024

softwarefactory-project-zuul bot commented Jun 17, 2024

softwarefactory-project-zuul bot commented Jun 17, 2024

raukadah commented Jun 19, 2024

marios left a comment

Choose a reason for hiding this comment

pablintino Jun 19, 2024

Choose a reason for hiding this comment

raukadah Jun 19, 2024

Choose a reason for hiding this comment

rebtoor commented Jun 19, 2024

openshift-ci bot commented Jun 19, 2024

frenzyfriday commented Jun 19, 2024

raukadah commented Jun 17, 2024 •

edited

Loading