Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the default building=yes for marketplace preset #4559

Closed
maraf24 opened this issue Nov 23, 2017 · 2 comments
Closed

Remove the default building=yes for marketplace preset #4559

maraf24 opened this issue Nov 23, 2017 · 2 comments
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag

Comments

@maraf24
Copy link

maraf24 commented Nov 23, 2017

The current preset for marketplace defaults to building=yes. Careless or inexperienced mapper misses the feature to turn the building tag off which leads to creation of non-existing building in the market square, as can be seen here
Even the wiki focuses on open-air marketplaces, with building=yes listed only as 'tag used in combination'.
Therefore I think it would be better to not add this tag automatically.

@bhousel bhousel added preset An issue with an OpenStreetMap preset or tag good first issue Best for first-time contributors. No experience necessary! labels Nov 24, 2017
@bhousel
Copy link
Member

bhousel commented Nov 24, 2017

This is a great task for someone who wants to learn how the iD presets work.

They are all defined in .json files.. The contents of the .json file define which fields iD will display.

The difference is: building_area is a combo field that defaults to yes if the user has drawn an area, and building is just a normal combo field that doesn't have a default value, but the user can still pick one if they choose to.

@bhousel
Copy link
Member

bhousel commented Nov 27, 2017

Done in #4568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

2 participants