add support for EPSG:4326 WMS layers #4858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrasd
changed the title
bhousel
reviewed
Mar 8, 2018
| y: lat * 180 / Math.PI | ||
| }; | ||
| default: // EPSG:3857 and synonyms | ||
| var mercCoords = d3_geoMercatorRaw(lon, lat); |
There was a problem hiding this comment.
oh wait nevermind, it's just moved
Interesting - that source also supports EPSG:4326. It looks like it's the same as CRS:84 but with x and y switched 🤔 |
Sounds good to me! I don't see a need to wait for that, so I'm just going to merge it as is. Thanks for the PR 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4843, follows #4814 – adds support for WMS'es supporting EPSG:4326 (WGS 84).
Are there any alternative codes for this projection around? I've seen
CRS:84in some places (examle), but I'm not actually sure where that one actually originates from…Also, it would be nice to do a similar analysis as in osmlab/editor-layer-index#425 for EPSG:4326 as well.