map features master checkbox #2998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhousel review please? |
kepta
force-pushed
the
2904
branch
2 times, most recently
from
42b7a89
to
1359264
Compare
Adds a master checkbox which selects/deselects all map features. (closes openstreetmap#2904)
|
So, this code is awesome and does exactly what it was supposed to do... I really like what you did. BUT, I thought about this some more and I'm going to add OpenStreetMap as a data layer here instead:
It makes more sense to me, post-#3001 layer refactor, and I want to reinforce the idea that OSM is just one of many layers that iD can support. We have more projects now where people are starting to fork iD and swap out OSM for something else, and I think this signals to them conceptually the cleanest way to do it.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a master checkbox which selects/deselects all map features.
(closes #2904)