-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data layer refactor #3001
Merged
Merged
Data layer refactor #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily addresses #2994 but also eliminates bunch of accumulated technical debt.
iD.svg.Surface
is nowiD.svg.Layers
and provides access to whatever vector layers we want to draw on top of the raster tiles.iD.Background
now draws just the background and nothing elseWhy now?
Because Mapillary proved how useful it is to draw data layers on top of the OSM data, and we want anyone else to be able to do that cleanly (not by hacking up
iD.Background
). Next stop: OSM notes.As simple as shuffling some layers around seems, this is in fact a big nasty refactor, but I'm feeling ok about it. I'm going to do a bunch of editing with it tonight and see if anything else is terribly broken.
There are a few other low hanging performance/usability things I'll probably sneak in:
When dragging POI markers, they jump slightly when you start to drag them. So we probably need to adjust the drag origin so that it matches the pointy part of the marker, not the center.Just realized this is broken in master, not something I broke in the refactor, so tracking on a new issue Improve Dragging Vertices and POI markers #3003position gets updatedimmediately goes away when resetting the surface transform. It currently does a funny thing: dragging makes the menu transition away, but if you do a quick drag and the surface has time to redraw, you can see it flicker to the wrong place just before it disappears. 34901d1