Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom WMS imagery URL templates #7510

Merged
merged 3 commits into from
May 18, 2020
Merged

Conversation

1ec5
Copy link
Collaborator

@1ec5 1ec5 commented Apr 12, 2020

Selectively cherry-picked parts of 1aa5e89, 2a28a03, and 2805c55 from #7428 so that the Custom Background Settings dialog can accept a WMS URL template. This PR only touches image URL template parsing; it leaves the editor-layer-index integration untouched. Unlike #6915, @bhousel’s implementation here properly distinguishes between WMS and TMS URLs.

Fixes #4977.

(closes #4977)

Before custom sources were assumed tms, now we detect wms
and guess 'EPSG:3857' projection
@1ec5 1ec5 added the enhancement An enhancement to make an existing feature even better label Apr 12, 2020
@1ec5 1ec5 self-assigned this Apr 12, 2020
@quincylvania quincylvania self-requested a review April 12, 2020 17:35
@quincylvania quincylvania mentioned this pull request Apr 28, 2020
Copy link
Collaborator

@quincylvania quincylvania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @1ec5, thanks for putting this together!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to make an existing feature even better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom WMS imagery
3 participants