Fix a few errors in note processing #8310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Notes still load over the xml api, so when the user is not authenticated, we can't use d3_json to fetch them (instead use to d3_xml) - Make sure to delete the deferred callback handles once the callbacks are processed (probably unnecessary, but good housekeeping) - Remove a stray `if (!json.elements)` block from the `parseUserJSON` function. This was preventing the user profile from parsing, as the user's JSON has no such property (was probably copied from `parseJSON`)
|
@bhousel Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can't use
d3_jsonto fetch them (instead used3_xml)processed (probably unnecessary, but good housekeeping)
if (!json.elements)block from theparseUserJSONfunction. This was preventing the user profile from parsing, as the
user's JSON has no such property (was probably copied from
parseJSON)