Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few errors in note processing #8310

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Fix a few errors in note processing #8310

merged 1 commit into from
Feb 5, 2021

Commits on Jan 21, 2021

  1. Fix a few errors in note processing

    - Notes still load over the xml api, so when the user is not authenticated,
      we can't use d3_json to fetch them (instead use to d3_xml)
    - Make sure to delete the deferred callback handles once the callbacks are
      processed (probably unnecessary, but good housekeeping)
    - Remove a stray `if (!json.elements)` block from the `parseUserJSON`
      function. This was preventing the user profile from parsing, as the
      user's JSON has no such property (was probably copied from `parseJSON`)
    bhousel committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    f195128 View commit details
    Browse the repository at this point in the history