-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Length Limit and Axle Weight Limit fields #911
Conversation
Also: * added these fields to moreFields of appropriate highway presets * changed maxweight field label to Weight Limit * swapped maxweight_bridge for maxweight field for Residential Road preset
🍱 Preview the tagging presets of this pull request here: https://pr-911--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
While you’re at it, this “Max” terminology also appears in the
These are called “Width Limit” or “Width Restriction” in the U.S., though few signs refer to the restriction by a noun. |
Renames: * `maxheight` field to 'Vertical Clearance' * `maxstay` field to 'Time Limit' * `maxwidth` field to `Width Limit`
data/fields/maxheight.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"key": "maxheight", | |||
"type": "roadheight", | |||
"label": "Max Height", | |||
"label": "Vertical Clearance", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though this term is officially used in the U.S., it may be less familiar to some users who see these signs and think of them as simply “height limits”. Fortunately, schema-builder lets you specify terms
for this field that will show up when searching for the field in iD. It’s probably a good idea to add all the previous labels as terms to accommodate existing users’ muscle memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 there is the distinction between the maximum legally allowed maximum height (maxheight
) versus the physical clearance (maxheight:physical
). I think the term vertical clearance could be misunderstood to mean the latter of the two…
Why be consistent by continuing the pattern to label all these fields as a “… Limit”, i.e. Height Limit
?
Adds fields for
maxlength
andmaxaxleload
. Labels match what MUTCD signs use:Also:
maxheight
field to 'Vertical Clearance'maxstay
field to 'Time Limit'maxwidth
field to 'Width Limit'