Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Length Limit and Axle Weight Limit fields #911

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

arch0345
Copy link
Contributor

@arch0345 arch0345 commented May 28, 2023

Adds fields for maxlength and maxaxleload. Labels match what MUTCD signs use:
image
image

Also:

  • added these fields to moreFields of appropriate highway presets
  • changed maxweight field label to Weight Limit to match MUTCD signage:
    image
  • swapped maxweight_bridge for maxweight field for Residential Road preset as it's more common for minor roads like these to have a weight limit that's not just at a bridge
  • renamed maxheight field to 'Vertical Clearance'
  • renamed maxstay field to 'Time Limit'
  • renamed maxwidth field to 'Width Limit'

Also:
* added these fields to moreFields of appropriate highway presets
* changed maxweight field label to Weight Limit
* swapped maxweight_bridge for maxweight field for Residential Road preset
@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-911--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@1ec5
Copy link
Contributor

1ec5 commented May 28, 2023

While you’re at it, this “Max” terminology also appears in the maxwidth field, which could be renamed to avoid abbreviating “maximum”:

"label": "Max Width",

These are called “Width Limit” or “Width Restriction” in the U.S., though few signs refer to the restriction by a noun.

Over 10 Feet Wide / Use Alternative Route

Renames:
* `maxheight` field to 'Vertical Clearance'
* `maxstay` field to 'Time Limit'
* `maxwidth` field to `Width Limit`
@@ -1,6 +1,6 @@
{
"key": "maxheight",
"type": "roadheight",
"label": "Max Height",
"label": "Vertical Clearance",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though this term is officially used in the U.S., it may be less familiar to some users who see these signs and think of them as simply “height limits”. Fortunately, schema-builder lets you specify terms for this field that will show up when searching for the field in iD. It’s probably a good idea to add all the previous labels as terms to accommodate existing users’ muscle memory.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 there is the distinction between the maximum legally allowed maximum height (maxheight) versus the physical clearance (maxheight:physical). I think the term vertical clearance could be misunderstood to mean the latter of the two…

Why be consistent by continuing the pattern to label all these fields as a “… Limit”, i.e. Height Limit?

@tyrasd tyrasd merged commit f8ecdeb into openstreetmap:main Jun 2, 2023
@arch0345 arch0345 deleted the max branch June 2, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants