Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Length Limit and Axle Weight Limit fields #911

Merged
merged 4 commits into from
Jun 2, 2023
Merged

Add Length Limit and Axle Weight Limit fields #911

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ada6f0d
Add Length Limit and Axle Weight Limit fields
arch0345 May 28, 2023
2b68882
Rename "Max" fields
arch0345 May 28, 2023
1daa8fd
Add 'max height' as a term for maxheight field
arch0345 May 28, 2023
1bb2709
Update maxheight.json
arch0345 May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions data/fields/maxaxleload_bridge.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"key": "maxaxleload",
"type": "combo",
"label": "Axle Weight Limit",
"snake_case": false,
"prerequisiteTag": {
"key": "bridge",
"valueNot": "no"
}
}
2 changes: 1 addition & 1 deletion data/fields/maxheight.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"key": "maxheight",
"type": "roadheight",
"label": "Max Height",
"label": "Vertical Clearance",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though this term is officially used in the U.S., it may be less familiar to some users who see these signs and think of them as simply “height limits”. Fortunately, schema-builder lets you specify terms for this field that will show up when searching for the field in iD. It’s probably a good idea to add all the previous labels as terms to accommodate existing users’ muscle memory.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 there is the distinction between the maximum legally allowed maximum height (maxheight) versus the physical clearance (maxheight:physical). I think the term vertical clearance could be misunderstood to mean the latter of the two…

Why be consistent by continuing the pattern to label all these fields as a “… Limit”, i.e. Height Limit?

"snake_case": false
}
6 changes: 6 additions & 0 deletions data/fields/maxlength.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"key": "maxlength",
"type": "roadheight",
"label": "Length Limit",
"snake_case": false
}
2 changes: 1 addition & 1 deletion data/fields/maxstay.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"key": "maxstay",
"type": "combo",
"label": "Max Stay",
"label": "Time Limit",
"options": [
"15 minutes",
"30 minutes",
Expand Down
2 changes: 1 addition & 1 deletion data/fields/maxweight.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"key": "maxweight",
"type": "combo",
"label": "Max Weight",
"label": "Weight Limit",
"snake_case": false
}
2 changes: 1 addition & 1 deletion data/fields/maxwidth.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"key": "maxwidth",
"type": "roadheight",
"label": "Max Width",
"label": "Width Limit",
"snake_case": false
}
2 changes: 2 additions & 0 deletions data/presets/highway/living_street.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
"flood_prone",
"junction_line",
"lit",
"maxaxleload_bridge",
"maxheight",
"maxlength",
"maxweight_bridge",
"maxwidth",
"oneway/bicycle",
Expand Down
2 changes: 2 additions & 0 deletions data/presets/highway/motorway.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"incline",
"junction_line",
"lit",
"maxaxleload_bridge",
"maxheight",
"maxlength",
"maxspeed/advisory",
"maxspeed/hgv",
"maxweight_bridge",
Expand Down
2 changes: 2 additions & 0 deletions data/presets/highway/motorway_link-US-CA.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
"incline",
"junction_line",
"lit",
"maxaxleload_bridge",
"maxheight",
"maxlength",
"maxspeed",
"maxweight_bridge",
"maxwidth",
Expand Down
2 changes: 2 additions & 0 deletions data/presets/highway/motorway_link.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
"incline",
"junction_line",
"lit",
"maxaxleload_bridge",
"maxheight",
"maxlength",
"maxspeed/advisory",
"maxweight_bridge",
"maxwidth",
Expand Down
2 changes: 2 additions & 0 deletions data/presets/highway/primary.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
"junction_line",
"lane_markings",
"lit",
"maxaxleload_bridge",
"maxheight",
"maxlength",
"maxspeed/advisory",
"maxspeed/hgv",
"maxweight_bridge",
Expand Down
2 changes: 2 additions & 0 deletions data/presets/highway/primary_link-US-CA.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
"junction_line",
"junction/ref_oneway",
"lit",
"maxaxleload_bridge",
"maxheight",
"maxlength",
"maxspeed",
"maxweight_bridge",
"maxwidth",
Expand Down
2 changes: 2 additions & 0 deletions data/presets/highway/primary_link.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
"junction_line",
"junction/ref_oneway",
"lit",
"maxaxleload_bridge",
"maxheight",
"maxlength",
"maxspeed/advisory",
"maxweight_bridge",
"maxwidth",
Expand Down
4 changes: 3 additions & 1 deletion data/presets/highway/residential.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@
"junction_line",
"lane_markings",
"lit",
"maxaxleload_bridge",
"maxheight",
"maxlength",
"maxspeed/advisory",
"maxweight_bridge",
"maxweight",
"maxwidth",
"not/name",
"oneway/bicycle",
Expand Down
2 changes: 2 additions & 0 deletions data/presets/highway/service.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
"incline",
"lanes",
"lit",
"maxaxleload_bridge",
"maxheight",
"maxlength",
"maxspeed/advisory",
"maxweight_bridge",
"maxwidth",
Expand Down
2 changes: 2 additions & 0 deletions data/presets/highway/trunk.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
"incline",
"junction_line",
"lit",
"maxaxleload_bridge",
"maxheight",
"maxlength",
"maxspeed/advisory",
"maxspeed/hgv",
"maxweight_bridge",
Expand Down