Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve auth with client credentials #286

Merged
merged 1 commit into from
Aug 19, 2024
Merged

feat: improve auth with client credentials #286

merged 1 commit into from
Aug 19, 2024

Conversation

jrschumacher
Copy link
Member

No description provided.

@jrschumacher jrschumacher requested a review from a team as a code owner August 16, 2024 16:27
@jrschumacher jrschumacher linked an issue Aug 16, 2024 that may be closed by this pull request
print-access-token is broken and no ability to get access token without caching when on linux #205
Closed
@jakedoublev
Copy link
Contributor

jakedoublev commented Aug 16, 2024 •
edited
Loading

  1. one auth session (type/token) per host
  2. immediate follow-up, per host per profile (when profile enhancement finished)
  3. store the host and credentials in the profile
  4. set the default profile to the keyring (plus inspect command to inspect current default profile)

Unsolved: finding a token storage not keyring for Linux to support user code auth (not client-credentials auth). Initial release could be no user auth or profiles supported on Linux.

@jakedoublev jakedoublev enabled auto-merge (squash) August 19, 2024 20:28
@jrschumacher jrschumacher disabled auto-merge August 19, 2024 20:29
@jrschumacher jrschumacher enabled auto-merge (squash) August 19, 2024 20:29
@jrschumacher jrschumacher merged commit 9c4968f into main Aug 19, 2024
6 checks passed
@jrschumacher jrschumacher deleted the 205-print-access-token-is-broken-and-no-ability-to-get-access-token-without-caching-when-on-linux branch August 19, 2024 20:30
@opentdf-automation opentdf-automation bot mentioned this pull request Aug 14, 2024
Merged
jrschumacher pushed a commit that referenced this pull request Aug 22, 2024
@opentdf-automation
chore: release 0.10.0 (#285)
00604bf 
🤖 I have created a release *beep* *boop*
---


## [0.10.0](v0.9.4...v0.10.0)
(2024-08-22)


### Features

* add profile support for cli
([#289](#289))
([15700f3](15700f3))
* **core:** add scaffolding and POC for auth code flow
([#144](#144))
([03ecbfb](03ecbfb))
* **core:** support kas grants to namespaces
([#292](#292))
([f2c6689](f2c6689)),
closes [#269](#269)
* improve auth with client credentials
([#286](#286))
([9c4968f](9c4968f))
* improve auth with client credentials
([#296](#296))
([0f533c7](0f533c7))


### Bug Fixes

* **core:** bump platform deps
([#276](#276))
([e4ced99](e4ced99))
* reduce prints ([#277](#277))
([8b5734a](8b5734a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakedoublev jakedoublev jakedoublev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

print-access-token is broken and no ability to get access token without caching when on linux
2 participants
@jrschumacher @jakedoublev