Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): auth code PKCE flow #144

Merged
merged 14 commits into from
Aug 19, 2024
Merged

feat(core): auth code PKCE flow #144

merged 14 commits into from
Aug 19, 2024

Conversation

jakedoublev
Copy link
Contributor

@jakedoublev jakedoublev commented May 3, 2024

First half of #170

Left in-flight:

  1. storage of the token (depends on feat: add profile support for cli #289)
  2. logout (depends on feat: add profile support for cli #289)
  3. refresh of access token for current profile if possible (depends on feat: add profile support for cli #289)
  4. authing to the SDK with just an access token from the code flow (SDK work needed upstream)

@jakedoublev
Copy link
Contributor Author

Blocked by opentdf/platform#1307

cmd/auth-code.go Outdated Show resolved Hide resolved
pkg/handlers/auth.go Outdated Show resolved Hide resolved
@jakedoublev
Copy link
Contributor Author

Is logout as "removing token from the machine" sufficient? What is LOE to revoke token based on well-known values?

@jakedoublev jakedoublev marked this pull request as ready for review August 19, 2024 21:11
@jakedoublev jakedoublev requested a review from a team as a code owner August 19, 2024 21:11
@jakedoublev jakedoublev enabled auto-merge (squash) August 19, 2024 21:24
@jakedoublev jakedoublev changed the title feat(core): add scaffolding and POC for auth code flow feat(core): auth code PKCE flow Aug 19, 2024
@jakedoublev jakedoublev merged commit 03ecbfb into main Aug 19, 2024
6 checks passed
@jakedoublev jakedoublev deleted the feat/auth-code branch August 19, 2024 21:45
jrschumacher pushed a commit that referenced this pull request Aug 22, 2024
🤖 I have created a release *beep* *boop*
---


## [0.10.0](v0.9.4...v0.10.0)
(2024-08-22)


### Features

* add profile support for cli
([#289](#289))
([15700f3](15700f3))
* **core:** add scaffolding and POC for auth code flow
([#144](#144))
([03ecbfb](03ecbfb))
* **core:** support kas grants to namespaces
([#292](#292))
([f2c6689](f2c6689)),
closes [#269](#269)
* improve auth with client credentials
([#286](#286))
([9c4968f](9c4968f))
* improve auth with client credentials
([#296](#296))
([0f533c7](0f533c7))


### Bug Fixes

* **core:** bump platform deps
([#276](#276))
([e4ced99](e4ced99))
* reduce prints ([#277](#277))
([8b5734a](8b5734a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants