Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add profile support for cli #289

Merged
merged 8 commits into from
Aug 21, 2024
Merged

feat: add profile support for cli #289

merged 8 commits into from
Aug 21, 2024

Conversation

jrschumacher
Copy link
Member

No description provided.

@jrschumacher jrschumacher requested a review from a team as a code owner August 19, 2024 14:10
@jrschumacher jrschumacher changed the title Iss-171-add-profiles feat: add profile support for cli Aug 19, 2024
jakedoublev
jakedoublev previously approved these changes Aug 19, 2024
Base automatically changed from 205-print-access-token-is-broken-and-no-ability-to-get-access-token-without-caching-when-on-linux to main August 19, 2024 20:30
@jrschumacher jrschumacher dismissed jakedoublev’s stale review August 19, 2024 20:30

The base branch was changed.

jakedoublev
jakedoublev previously approved these changes Aug 21, 2024
Copy link
Contributor

@jakedoublev jakedoublev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge and continue to massage as we finish the auth token flow. I think making sure the e2e test passes will ensure backwards compatibility with --with-client-creds-file though so is probably good to fix now?

Co-authored-by: Jake Van Vorhis <83739412+jakedoublev@users.noreply.github.com>
jakedoublev
jakedoublev previously approved these changes Aug 21, 2024
@jrschumacher jrschumacher merged commit 15700f3 into main Aug 21, 2024
6 checks passed
@jrschumacher jrschumacher deleted the iss-171-add-profiles branch August 21, 2024 22:47
jrschumacher pushed a commit that referenced this pull request Aug 22, 2024
🤖 I have created a release *beep* *boop*
---


## [0.10.0](v0.9.4...v0.10.0)
(2024-08-22)


### Features

* add profile support for cli
([#289](#289))
([15700f3](15700f3))
* **core:** add scaffolding and POC for auth code flow
([#144](#144))
([03ecbfb](03ecbfb))
* **core:** support kas grants to namespaces
([#292](#292))
([f2c6689](f2c6689)),
closes [#269](#269)
* improve auth with client credentials
([#286](#286))
([9c4968f](9c4968f))
* improve auth with client credentials
([#296](#296))
([0f533c7](0f533c7))


### Bug Fixes

* **core:** bump platform deps
([#276](#276))
([e4ced99](e4ced99))
* reduce prints ([#277](#277))
([8b5734a](8b5734a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
@jrschumacher jrschumacher linked an issue Aug 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: CLI config should support profiles
2 participants