-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add profile support for cli #289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakedoublev
reviewed
Aug 19, 2024
jakedoublev
previously approved these changes
Aug 19, 2024
Base automatically changed from
205-print-access-token-is-broken-and-no-ability-to-get-access-token-without-caching-when-on-linux
to
main
August 19, 2024 20:30
jrschumacher
dismissed
jakedoublev’s stale review
August 19, 2024 20:30
The base branch was changed.
jakedoublev
previously approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge and continue to massage as we finish the auth token flow. I think making sure the e2e test passes will ensure backwards compatibility with --with-client-creds-file
though so is probably good to fix now?
Co-authored-by: Jake Van Vorhis <83739412+jakedoublev@users.noreply.github.com>
jakedoublev
previously approved these changes
Aug 21, 2024
jakedoublev
approved these changes
Aug 21, 2024
Merged
jrschumacher
pushed a commit
that referenced
this pull request
Aug 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.10.0](v0.9.4...v0.10.0) (2024-08-22) ### Features * add profile support for cli ([#289](#289)) ([15700f3](15700f3)) * **core:** add scaffolding and POC for auth code flow ([#144](#144)) ([03ecbfb](03ecbfb)) * **core:** support kas grants to namespaces ([#292](#292)) ([f2c6689](f2c6689)), closes [#269](#269) * improve auth with client credentials ([#286](#286)) ([9c4968f](9c4968f)) * improve auth with client credentials ([#296](#296)) ([0f533c7](0f533c7)) ### Bug Fixes * **core:** bump platform deps ([#276](#276)) ([e4ced99](e4ced99)) * reduce prints ([#277](#277)) ([8b5734a](8b5734a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.