Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: enhance linting in pipeline #325

Closed
jakedoublev opened this issue Aug 26, 2024 · 0 comments · Fixed by #363
Closed

CI: enhance linting in pipeline #325

jakedoublev opened this issue Aug 26, 2024 · 0 comments · Fixed by #363
Assignees
@jakedoublev

Comments

@jakedoublev
Copy link
Contributor

There are several lint warnings throughout otdfctl. We should employ stronger golang lint settings and fix any existing lint errors/warnings.

Reference:
https://github.com/opentdf/platform/blob/main/.github/workflows/checks.yaml#L64-L70

Acceptance Criteria

  1. any existing lint issues are resolved
  2. every change or new addition in a .go file is properly linted
@jakedoublev jakedoublev self-assigned this Aug 26, 2024
@jakedoublev jakedoublev mentioned this issue Sep 4, 2024
Merged
jrschumacher pushed a commit that referenced this issue Sep 6, 2024
@jakedoublev
fix(ci): enhance lint config and resolve all lint issues (#363)
5c1dbf1 
Resolves #325 

Resolves several:
1. shadow declarations
2. magic numbers
3. unused declarations

Ignores several cases where:
1.  if/else is better than switch
2. magic numbers when styling are more maintainable than variables
3. the TUI package is in too much flux to properly lint yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakedoublev jakedoublev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ci): enhance lint config and resolve all lint issues opentdf/otdfctl
2 participants
@jakedoublev and others