Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): enhance lint config and resolve all lint issues #363

Merged
merged 11 commits into from
Sep 6, 2024
Merged

fix(ci): enhance lint config and resolve all lint issues #363

merged 11 commits into from
Sep 6, 2024

Conversation

jakedoublev
Copy link
Contributor

@jakedoublev jakedoublev commented Sep 4, 2024 •
edited
Loading

Resolves #325

Resolves several:

  1. shadow declarations
  2. magic numbers
  3. unused declarations

Ignores several cases where:

  1. if/else is better than switch
  2. magic numbers when styling are more maintainable than variables
  3. the TUI package is in too much flux to properly lint yet

@jakedoublev jakedoublev requested a review from a team as a code owner September 4, 2024 19:09
@jakedoublev jakedoublev changed the title fix(ci): bump golangci-lint version in GHA fix(ci): enhance lint config and resolve all lint issues Sep 4, 2024
@jrschumacher jrschumacher merged commit 5c1dbf1 into main Sep 6, 2024
8 checks passed
@jrschumacher jrschumacher deleted the fix/lint branch September 6, 2024 19:28
@opentdf-automation opentdf-automation bot mentioned this pull request Sep 9, 2024
Merged
jakedoublev pushed a commit that referenced this pull request Sep 12, 2024
@opentdf-automation
chore(main): release 0.13.0 (#342)
fd76f0e 
🤖 I have created a release *beep* *boop*
---


##
[0.13.0](v0.12.2...v0.13.0)
(2024-09-12)


### Features

* add cli test mode and profile tests
([#313](#313))
([e0bc183](e0bc183))
* **ci:** make e2e test workflow reusable
([#365](#365))
([d94408c](d94408c))
* **ci:** namespaces e2e tests and test suite improvements
([#351](#351))
([ce28555](ce28555))
* **ci:** reusable platform composite action in e2e tests
([#369](#369))
([f7d5a1c](f7d5a1c))
* **core:** add ecdsa-binding encrypt flag
([#360](#360))
([8702ec0](8702ec0))
* **core:** adds missing long manual output docs
([#362](#362))
([8e1390f](8e1390f)),
closes [#359](#359)
* **core:** kas-grants list
([#346](#346))
([7f51282](7f51282)),
closes [#253](#253)


### Bug Fixes

* **ci:** e2e workflow should be fully reusable
([#368](#368))
([cc1e2b9](cc1e2b9))
* **ci:** enhance lint config and resolve all lint issues
([#363](#363))
([5c1dbf1](5c1dbf1))
* **core:** GOOS, error message fixes
([#378](#378))
([623a82a](623a82a)),
closes [#380](#380)
* **core:** metadata rendering cleanup
([#293](#293))
([ed21f81](ed21f81))
* **core:** wire attribute value FQNs to encrypt
([#370](#370))
([21f9b80](21f9b80))
* refactor to support varying print output
([#350](#350))
([d6932f3](d6932f3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrschumacher jrschumacher jrschumacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: enhance linting in pipeline
2 participants
@jakedoublev @jrschumacher