Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add ecdsa-binding encrypt flag #360

Merged
merged 8 commits into from
Sep 5, 2024

Conversation

dmihalcik-virtru
Copy link
Member

  • this enables the optional 'ecdsa binding' feature in nanotdf containers

- this enables the optional 'ecdsa binding' feature in nanotdf containers
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner September 4, 2024 16:44
@dmihalcik-virtru dmihalcik-virtru changed the title feat(nano): add ecdsa-binding encrypt flag feat(core): add ecdsa-binding encrypt flag Sep 4, 2024
pflynn-virtru
pflynn-virtru previously approved these changes Sep 4, 2024
@jakedoublev
Copy link
Contributor

This looks good. Can we please add an e2e test for this functionality to verify? https://github.com/opentdf/otdfctl/blob/main/tests/encrypt-decrypt.bats#L50

Copy link
Member

@jrschumacher jrschumacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing due to missing flag string

cmd/tdf-inspect.go Show resolved Hide resolved
tests/encrypt-decrypt.bats Outdated Show resolved Hide resolved
tests/encrypt-decrypt.bats Outdated Show resolved Hide resolved
@jrschumacher jrschumacher merged commit 8702ec0 into main Sep 5, 2024
7 checks passed
@jrschumacher jrschumacher deleted the feature/ecdsa-binding-parameter branch September 5, 2024 13:16
jakedoublev pushed a commit that referenced this pull request Sep 12, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.13.0](v0.12.2...v0.13.0)
(2024-09-12)


### Features

* add cli test mode and profile tests
([#313](#313))
([e0bc183](e0bc183))
* **ci:** make e2e test workflow reusable
([#365](#365))
([d94408c](d94408c))
* **ci:** namespaces e2e tests and test suite improvements
([#351](#351))
([ce28555](ce28555))
* **ci:** reusable platform composite action in e2e tests
([#369](#369))
([f7d5a1c](f7d5a1c))
* **core:** add ecdsa-binding encrypt flag
([#360](#360))
([8702ec0](8702ec0))
* **core:** adds missing long manual output docs
([#362](#362))
([8e1390f](8e1390f)),
closes [#359](#359)
* **core:** kas-grants list
([#346](#346))
([7f51282](7f51282)),
closes [#253](#253)


### Bug Fixes

* **ci:** e2e workflow should be fully reusable
([#368](#368))
([cc1e2b9](cc1e2b9))
* **ci:** enhance lint config and resolve all lint issues
([#363](#363))
([5c1dbf1](5c1dbf1))
* **core:** GOOS, error message fixes
([#378](#378))
([623a82a](623a82a)),
closes [#380](#380)
* **core:** metadata rendering cleanup
([#293](#293))
([ed21f81](ed21f81))
* **core:** wire attribute value FQNs to encrypt
([#370](#370))
([21f9b80](21f9b80))
* refactor to support varying print output
([#350](#350))
([d6932f3](d6932f3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants