fix(core): policy db should use pool connection hook to set search_path #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested these changes under simulated flakiness with: Every time, I got a log: I never had a failed policy LIST attributes call. Running the same test on |
strantalis
previously approved these changes
Aug 22, 2024
strantalis
approved these changes
Aug 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.21](service/v0.4.20...service/v0.4.21) (2024-08-23) ### Features * **core:** KID in NanoTDF KAS ResourceLocator borrowed from Protocol ([#1222](#1222)) ([e5ee4ef](e5ee4ef)) ### Bug Fixes * **authz:** entitlements fqn casing ([#1446](#1446)) ([2ffc66b](2ffc66b)), closes [#1359](#1359) * **core:** Autobump service ([#1417](#1417)) ([e6db378](e6db378)) * **core:** Autobump service ([#1441](#1441)) ([e17deab](e17deab)) * **core:** Autobump service ([#1449](#1449)) ([7e443da](7e443da)) * **core:** case sensitivity in AccessPDP ([#1439](#1439)) ([aed7633](aed7633)), closes [#1359](#1359) * **core:** policy db should use pool connection hook to set search_path ([#1443](#1443)) ([8501ff5](8501ff5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1442
Instead of executing the
SET search_pathon the first connection found when a pool is instantiated, we should utilize theAfterConnectPGX hook which exposes a connection immediately after it's opened and before it's utilized.