Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authz): entitlements fqn casing #1446

Merged
merged 4 commits into from
Aug 23, 2024
Merged

fix(authz): entitlements fqn casing #1446

merged 4 commits into from
Aug 23, 2024

Conversation

suchak1
Copy link
Contributor

@suchak1 suchak1 commented Aug 23, 2024

Closes #1359

@suchak1 suchak1 requested a review from a team as a code owner August 23, 2024 15:27
@suchak1 suchak1 changed the title fix(auth): entitlements fqn casing fix(authz): entitlements fqn casing Aug 23, 2024
Copy link
Contributor

Warning

This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description.

@jakedoublev
Copy link
Contributor

✅ from me. I was able to test successfully with otdfctl and an encrypt/decrypt flow where the encryption was with a mixed case attribute and there were valid entitlements.

Copy link
Member

@ttschampel ttschampel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a unit test for this case sensitive flow?

@strantalis strantalis requested a review from ttschampel August 23, 2024 19:17
@strantalis strantalis added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit 2ffc66b Aug 23, 2024
19 checks passed
@strantalis strantalis deleted the fix/fqn-casing branch August 23, 2024 20:11
github-merge-queue bot pushed a commit that referenced this pull request Aug 23, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.4.21](service/v0.4.20...service/v0.4.21)
(2024-08-23)


### Features

* **core:** KID in NanoTDF KAS ResourceLocator borrowed from Protocol
([#1222](#1222))
([e5ee4ef](e5ee4ef))


### Bug Fixes

* **authz:** entitlements fqn casing
([#1446](#1446))
([2ffc66b](2ffc66b)),
closes [#1359](#1359)
* **core:** Autobump service
([#1417](#1417))
([e6db378](e6db378))
* **core:** Autobump service
([#1441](#1441))
([e17deab](e17deab))
* **core:** Autobump service
([#1449](#1449))
([7e443da](7e443da))
* **core:** case sensitivity in AccessPDP
([#1439](#1439))
([aed7633](aed7633)),
closes [#1359](#1359)
* **core:** policy db should use pool connection hook to set search_path
([#1443](#1443))
([8501ff5](8501ff5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TDF Policy Data Attributes are case sensitive
4 participants