🚧 FileSystem API in web-app #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmihalcik-virtru
force-pushed
the
feature/file-system-api
branch
from
294cddb to
cdd0c63
Compare
dmihalcik-virtru
force-pushed
the
feature/file-system-api
branch
from
cdd0c63 to
d84b00d
Compare
Replaces download link generation with FileSystemAccess API implementation of streaming downloads for tdf3 (and html wrapped, kinda) containers. Works fine for tdf files (not HTML wrapped) of arbitrary size. HOWEVER: the showSaveFilePicker is unsupported by Playwright, so any CI implementation might have to mock the whole thing. Update App.tsx
dmihalcik-virtru
force-pushed
the
feature/file-system-api
branch
from
d84b00d to
636497c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Moved this work into the bigger demo PR #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces download link generation with FileSystemAccess API implementation of streaming downloads for tdf3 (and html wrapped, kinda) containers. Works fine for tdf files (not HTML wrapped) of arbitrary size.
HOWEVER: the showSaveFilePicker is unsupported by Playwright, so any CI implementation might have to mock the whole thing.